Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AoC leaderboard upload ot use new paste service #110

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

ChrisLovering
Copy link
Member

No description provided.

Copy link
Member

@shtlrs shtlrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test this, but the change looks safe and good to me.

@janine9vn
Copy link
Collaborator

I'm getting this as an error when I test it. Is it something about my settings/config that's wrong?
image

@ChrisLovering
Copy link
Member Author

I'm getting this as an error when I test it. Is it something about my settings/config that's wrong?

You're probably not doing anything wrong. I didn't get a chance to test it when I made this, then quickly forgot about it.

Will give it a look later today.

@ChrisLovering
Copy link
Member Author

@janine9vn this issue was being caused by the max paste limit.

In the force push I've had to limit the leader board output to only the top 1000 so that we don't hit that.

Copy link
Collaborator

@janine9vn janine9vn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and now works with the top 1000 limit. Maybe in many years we'll have to deal with more than 1,000 active participants but that's a very-future-us problem.

@ChrisLovering ChrisLovering merged commit 5754a9c into main Dec 8, 2023
3 checks passed
@ChrisLovering ChrisLovering deleted the use-new-pasteservice branch December 8, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants