Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing - 'test_basic.py', 'base.py', 'column.py', 'test_abnormal.py', 'benchmark.py' #82

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

soulee-dev
Copy link

No description provided.

@soulee-dev
Copy link
Author

현재 문제가 발생하는 테스트 수정 해놓겠습니다

@soulee-dev
Copy link
Author

  • mypy로 한번 테스트 돌려보고, 몇가지 타입 힌트 추가
mypy pymysqlreplication/tests/ --check-untyped-defs --allow-redefinition
  • 작동하지 않는 테스트 수정

파일당 하나의 커밋으로 squash 진행 하겠습니다

Copy link

@dongwook-chan dongwook-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼하게 typing 적용 잘 해주셨습니다! 다들 고생 많으셨어요!! 👍🏻👍🏻👍🏻

@soulee-dev
Copy link
Author

feat : mirageoasis typing complete > test_basic.py
Add type annotations to test_abnormal.py > test_abnormal.py
Add type annotations to column.py > column.py
Add type annotations to benchmark.py > benchmark.py
add: type hint for test_basic.py > test_basic.py
fix: return value for test_drop_column > test_basic.py
Add type annotations to base.py > base.py
Fix formatting to base.py > base.py
fix: remove unused imports > test_basic.py
fix: import pymysql.cursors always > base.py
add: type hints for PyMyReplTestCase > base.py
add: type hints for connections > benchmark.py
add: type hints for stream > test_abnormal.py
fix: wrong type hint for Gtid > test_basic.py
fix: add bytes to query string > test_basic.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1조 1조 이슈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants