GH-121970: Rewrite the C-API annotations extension #121985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
added
needs backport to 3.12
encukou
reviewed
Jul 19, 2024
Co-authored-by: Petr Viktorin <[email protected]>
encukou
approved these changes
Jul 19, 2024
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @AA-Turner, I could not cleanly backport this to |
|
Sorry, @AA-Turner, I could not cleanly backport this to |
AA-Turner
added
needs backport to 3.12
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @AA-Turner, I could not cleanly backport this to |
AA-Turner
added a commit
to AA-Turner/cpython
that referenced
this pull request
Jul 19, 2024
…onGH-121985) (cherry picked from commit 22c9d9c) Co-authored-by: Adam Turner <[email protected]> Co-authored-by: Petr Viktorin <[email protected]>
|
GH-122025 is a backport of this pull request to the 3.12 branch. |
AA-Turner
added a commit
to AA-Turner/cpython
that referenced
this pull request
Jul 19, 2024
Co-authored-by: Petr Viktorin <[email protected]> (cherry picked from commit 22c9d9c)
|
GH-122027 is a backport of this pull request to the 3.13 branch. |
AA-Turner
added a commit
that referenced
this pull request
Jul 19, 2024
…#122025) (cherry picked from commit 22c9d9c) Co-authored-by: Petr Viktorin <[email protected]>
AA-Turner
added a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested the output before and after this commit, entirely equal save for a new link target in
c-api/module.html#c.Py_mod_create.create_moduleandc-api/module.html#c.Py_mod_exec.exec_module(because we switch from patching in:noindex:to using the C Domain's supported:no-index-entry:).This introduces some new dataclasses, removes the state stored in closures and the
Annotatedclass instance, and does some small cleanups. Notably,stable_abi.datis changed to storing the role name rather than the object type, which simplifies things a little.A
📚 Documentation preview 📚: https://cpython-previews--121985.org.readthedocs.build/en/121985/c-api/index.html
pyspecific#121970