Avoid false unreachable and redundant-expr warnings in loops.
#18433
Conversation
Fixes python#18348 Fixes python#13973 Fixes python#11612 Fixes python#8721 Fixes python#8865 Fixes python#7204 I manually checked all the listed issues. Some of them were already partly fixed by python#18180.
This comment has been minimized.
This comment has been minimized.
|
Such a long primer diff. It seems like I enabled |
mypy/checker.py
Outdated
| if warn_unreachable or warn_redundant: | ||
| self.options.warn_unreachable = warn_unreachable | ||
| self.options.enabled_error_codes.add(codes.REDUNDANT_EXPR) | ||
| with self.binder.frame_context(can_skip=True, break_frame=2, continue_frame=1): | ||
| self.accept(body) |
There was a problem hiding this comment.
| if warn_unreachable or warn_redundant: | |
| self.options.warn_unreachable = warn_unreachable | |
| self.options.enabled_error_codes.add(codes.REDUNDANT_EXPR) | |
| with self.binder.frame_context(can_skip=True, break_frame=2, continue_frame=1): | |
| self.accept(body) | |
| if warn_unreachable: | |
| self.options.warn_unreachable = warn_unreachable | |
| if warn_redundant: | |
| self.options.enabled_error_codes.add(codes.REDUNDANT_EXPR) | |
| if warn_unreachable or warn_redundant: | |
| with self.binder.frame_context(can_skip=True, break_frame=2, continue_frame=1): | |
| self.accept(body) |
Maybe something like this?
There was a problem hiding this comment.
Yes, thank you, that should work. I wrote slightly differently yesterday but then lost my internet connection and now pushed it before seeing this comment. If you prefer your version (and can accept the general solution), please feel free to edit the section before merging.
|
Diff from mypy_primer, showing the effect of this PR on open source code: bandersnatch (https://github.com/pypa/bandersnatch)
+ src/bandersnatch_storage_plugins/s3.py:62: error: Unused "type: ignore" comment [unused-ignore]
core (https://github.com/home-assistant/core)
+ homeassistant/components/recorder/migration.py:2283: error: Unused "type: ignore" comment [unused-ignore]
+ homeassistant/components/recorder/migration.py:2305: error: Unused "type: ignore" comment [unused-ignore]
+ homeassistant/components/schedule/__init__.py:76: error: Unused "type: ignore" comment [unused-ignore]
+ homeassistant/components/twentemilieu/calendar.py:73: error: Unused "type: ignore" comment [unused-ignore]
pyodide (https://github.com/pyodide/pyodide)
+ src/py/pyodide/_state.py:21: error: Incompatible types in assignment (expression has type "pyodide._state.<subclass of "ModuleType" and "JsProxy">2", target has type "pyodide._state.<subclass of "ModuleType" and "JsProxy">") [assignment]
|
|
Regarding pypa/bandersnatch and home-assistant/core, the diff looks good. Regarding pyodide/pyodide, I neither understand why this error is emitted now nor why it is emitted in general (confusing error message). Maybe you know this behaviour already. I could investigate later. |
Fixes #18348
Fixes #13973
Fixes #11612
Fixes #8721
Fixes #8865
Fixes #7204
I manually checked all the listed issues. Some of them were already partly fixed by #18180.