-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stub content/style section from CONTRIBUTING.md #13332
base: main
Are you sure you want to change the base?
Conversation
This reminds me of an old PR by @srittau and reviewed by @JelleZijlstra that went unmerged https://github.com/python/typeshed/pull/7594/files |
The only extra thing that PR deletes is the "Supported type system features" section. The comments mentioned linking to the issue tracker:
project: feature tracker
Perhaps we can do that in a separate PR? |
I don't think this is a good idea. I think CONTRIBUTING.md should be a self-contained document that you read, and then you can contribute. It should be as painless as possible to go through, so it shouldn't expect readers to follow links and read something elsewhere. That said, "for more info see also" type of links are ok in a CONTRIBUTING.md. |
it's not possible to accurately type an item using the current type system. | ||
It should be used sparingly. | ||
|
||
### "The `Any` trick" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Any
trick is a good example of a "for more info, see also" kind of thing. Most contributors won't need to know about it, so it is IMO a good idea to link to it from CONTRIBUTING.md, but not explain it here.
The main motivation for removing the whole section from As a point of comparison, the DefinitelyTyped repo's README doesn't include detailed info on how to write typescript definitions, it links to the official docs. |
python/typing#1882 has added the stub content/style guidelines from
CONTRIBUTING.md
to the official typing documentation (https://typing.readthedocs.io/en/latest/guides/writing_stubs.html), so we can change the contributing guide to link to that directly.I added a special note re: omitting docstrings from typeshed, since the official docs only discusses tradeoffs (per Jelle's recommendation in python/typing#1880 (comment))