Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sparsity, target-size and sort_by_length for hstu #62

Closed
wants to merge 4 commits into from

Conversation

manman-ren
Copy link
Contributor

@manman-ren manman-ren commented Nov 21, 2024

Copied over generate_sparse_seq_len
Example output
x_val hstu_triton_ragged_attention-latency


(256, 4, 16384, 2048, 0.8, 20, False) 146.458
(256, 4, 16384, 2048, 0.8, 20, False) 148.616
(256, 4, 16384, 2048, 0.8, 20, False) 145.135
(256, 4, 16384, 2048, 0.8, 20, False) 148.98
(256, 4, 16384, 2048, 0.8, 20, False) 147.167
(256, 4, 16384, 2048, 0.8, 20, False) 146.155
(256, 4, 16384, 2048, 0.8, 20, False) 144.787
(256, 4, 16384, 2048, 0.8, 20, False) 144.055
(256, 4, 16384, 2048, 0.8, 20, False) 144.35
(256, 4, 16384, 2048, 0.8, 20, False) 146.67

@manman-ren manman-ren requested a review from xuzhao9 November 21, 2024 01:11
@manman-ren manman-ren requested review from bertmaher and htyu November 21, 2024 01:11
@manman-ren manman-ren changed the title support target-size and sparsity for hstu Support target-size and sparsity for hstu Nov 21, 2024
@manman-ren manman-ren changed the title Support target-size and sparsity for hstu Support sparsity, target-size and sort_by_length for hstu Nov 21, 2024
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@facebook-github-bot
Copy link
Contributor

@manman-ren has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xuzhao9
Copy link
Contributor

xuzhao9 commented Nov 21, 2024

Can we have example output from running the operator?

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@manman-ren has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@facebook-github-bot
Copy link
Contributor

@manman-ren has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@manman-ren merged this pull request in 45d195c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants