Add test coverage for futures in ShapleyValueSampling 1/n #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68229981 |
jjuncho
added a commit
that referenced
this pull request
Jan 18, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
jjuncho
added a commit
that referenced
this pull request
Jan 18, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
jjuncho
added a commit
that referenced
this pull request
Jan 18, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
jjuncho
force-pushed
the
export-D68229981
branch
from
f1a7a34 to
0122bce
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68229981 |
jjuncho
added a commit
that referenced
this pull request
Jan 18, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
jjuncho
added a commit
that referenced
this pull request
Jan 21, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
jjuncho
added a commit
that referenced
this pull request
Jan 21, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
jjuncho
added a commit
that referenced
this pull request
Jan 21, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
jjuncho
added a commit
that referenced
this pull request
Jan 21, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
jjuncho
force-pushed
the
export-D68229981
branch
from
0122bce to
37d08f7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68229981 |
facebook-github-bot
force-pushed
the
export-D68229981
branch
from
37d08f7 to
b914416
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68229981 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
facebook-github-bot
force-pushed
the
export-D68229981
branch
from
b914416 to
223afa3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68229981 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
facebook-github-bot
force-pushed
the
export-D68229981
branch
from
223afa3 to
5127046
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68229981 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
facebook-github-bot
force-pushed
the
export-D68229981
branch
from
5127046 to
4ef915b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68229981 |
jjuncho
added a commit
that referenced
this pull request
Jan 22, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
jjuncho
added a commit
that referenced
this pull request
Jan 22, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
jjuncho
added a commit
that referenced
this pull request
Jan 22, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
jjuncho
force-pushed
the
export-D68229981
branch
from
4ef915b to
e8d9620
Compare
jjuncho
added a commit
that referenced
this pull request
Jan 22, 2025
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
|
This pull request was exported from Phabricator. Differential Revision: D68229981 |
Summary: This diff implements the attribute_future method for the ShapleyValueSampling class. Reviewed By: cyrjano Differential Revision: D68158802
Summary: This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear Reviewed By: cyrjano Differential Revision: D68229981
facebook-github-bot
force-pushed
the
export-D68229981
branch
from
e8d9620 to
a123ac7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68229981 |
|
This pull request has been merged in fc6df48. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diffs adds more testing coverage for attribute_future to ShapleyValueSampling unit tests that handle simple shapley sampling and multi shapley sampling using the BasicModel_MultiLayer model
note: decided to parameterize the high-level unit tests since I did not want to clutter the unit test file with tests which were doing the same calculations but with the pytorch futures api. Separated the model and shapley assert methods between non-future vs future so that the differences between the two would be clear
Reviewed By: cyrjano
Differential Revision: D68229981