[executorch][serialization] Refactor flatbuffer utils into separate file #7254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For usage in extension/flat_tensor/serialize. Differential Revision: [D66854756](https://our.internmc.facebook.com/intern/diff/D66854756/) [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7254
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 30170b0 with merge base d3e58b0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D66854756 |
This was referenced Dec 9, 2024
… separate file" For usage in extension/flat_tensor/serialize. Differential Revision: [D66854756](https://our.internmc.facebook.com/intern/diff/D66854756/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66854756 |
swolchok
approved these changes
Dec 13, 2024
… separate file" For usage in extension/flat_tensor/serialize. Differential Revision: [D66854756](https://our.internmc.facebook.com/intern/diff/D66854756/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Dec 18, 2024
Pull Request resolved: #7254 Todo: let xnnpack and vulkan serialization use these utils instead of redefining the same functions. For usage in extension/flat_tensor/serialize. ghstack-source-id: 258747562 @exported-using-ghexport Differential Revision: [D66854756](https://our.internmc.facebook.com/intern/diff/D66854756/)
|
This pull request was exported from Phabricator. Differential Revision: D66854756 |
… separate file" For usage in extension/flat_tensor/serialize. Differential Revision: [D66854756](https://our.internmc.facebook.com/intern/diff/D66854756/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66854756 |
lucylq
added a commit
that referenced
this pull request
Dec 21, 2024
Pull Request resolved: #7254 Todo: let xnnpack and vulkan serialization use these utils instead of redefining the same functions. For usage in extension/flat_tensor/serialize. ghstack-source-id: 259211956 @exported-using-ghexport Differential Revision: [D66854756](https://our.internmc.facebook.com/intern/diff/D66854756/)
… separate file" For usage in extension/flat_tensor/serialize. Differential Revision: [D66854756](https://our.internmc.facebook.com/intern/diff/D66854756/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Jan 2, 2025
Pull Request resolved: #7254 Todo: let xnnpack and vulkan serialization use these utils instead of redefining the same functions. For usage in extension/flat_tensor/serialize. ghstack-source-id: 260014612 @exported-using-ghexport Differential Revision: [D66854756](https://our.internmc.facebook.com/intern/diff/D66854756/)
|
This pull request was exported from Phabricator. Differential Revision: D66854756 |
… separate file" For usage in extension/flat_tensor/serialize. Differential Revision: [D66854756](https://our.internmc.facebook.com/intern/diff/D66854756/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Jan 2, 2025
Pull Request resolved: #7254 Todo: let xnnpack and vulkan serialization use these utils instead of redefining the same functions. For usage in extension/flat_tensor/serialize. ghstack-source-id: 260036856 @exported-using-ghexport Differential Revision: [D66854756](https://our.internmc.facebook.com/intern/diff/D66854756/)
|
This pull request was exported from Phabricator. Differential Revision: D66854756 |
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
lucylq
added a commit
that referenced
this pull request
Jan 3, 2025
…ile (#7488) Pull Request resolved: #7254 Todo: let xnnpack and vulkan serialization use these utils instead of redefining the same functions. For usage in extension/flat_tensor/serialize. ghstack-source-id: 260036856 @exported-using-ghexport Differential Revision: [D66854756](https://our.internmc.facebook.com/intern/diff/D66854756/) Co-authored-by: lucylq <[email protected]>
lucylq
added a commit
that referenced
this pull request
Jan 4, 2025
* [executorch][serialization] Data serialization interface Pull Request resolved: #7194 Introduce data serialization interface. ghstack-source-id: 260014193 @exported-using-ghexport Differential Revision: [D65947145](https://our.internmc.facebook.com/intern/diff/D65947145/) * [executorch][serialization] Refactor flatbuffer utils into separate file (#7488) Pull Request resolved: #7254 Todo: let xnnpack and vulkan serialization use these utils instead of redefining the same functions. For usage in extension/flat_tensor/serialize. ghstack-source-id: 260036856 @exported-using-ghexport Differential Revision: [D66854756](https://our.internmc.facebook.com/intern/diff/D66854756/) Co-authored-by: lucylq <[email protected]> --------- Co-authored-by: lucylq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
For usage in extension/flat_tensor/serialize.
Differential Revision: D66854756