Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visualization to devtools #7554

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add visualization to devtools #7554

wants to merge 1 commit into from
+295 −0

Conversation

Erik-Lundell
Copy link
Collaborator

  • Add ai-edge-model-explorer as development requirement
  • Add lightweight wrapper around model-explorer in devtools
  • Use it in .visualize() call in XNNPack tester
  • Add tests. The actual call to model-explorer is mocked, since getting it to run in ci did not work out. However, asserting that the model actually loads properly needs visual inspection anyways. Instead, visualization_utils_test.py can be run locally.
  • Add two context managers for starting model-explorer servers, currently only used for testing but might be useful.

See discussion here #6750

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7554

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3ae2b41 with merge base 08770b7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 8, 2025
@Erik-Lundell Erik-Lundell mentioned this pull request Jan 8, 2025
Closed
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm module: devtools Features or issues related to profiling, debugging, bundled program, etc. topic: not user facing labels Jan 8, 2025
@Erik-Lundell
Add visualization to devtools
3ae2b41 
- Add ai-edge-model-explorer as development requirement
- Add lightweight wrapper around model-explorer in devtools
- Use it in .visualize() call in XNNPack tester
- Add tests. The actual call to model-explorer is mocked, since
  getting it to run in ci did not work out. However, asserting
  that the model actually loads properly needs visual inspection anyways.
  Instead, visualization_utils_test.py can be run locally.
- Add two context managers for starting model-explorer servers,
  currently only used for testing but might be useful.

Signed-off-by: Erik Lundell <[email protected]>
Change-Id: I3fc0efb3a2012b038f699f7737c4d97c5039df40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olivia-liu Olivia-liu Awaiting requested review from Olivia-liu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: devtools Features or issues related to profiling, debugging, bundled program, etc. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Erik-Lundell @facebook-github-bot