Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dim order assert #7561

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

neuropilot-captain
Copy link
Contributor

  • Add assert to AOT and runtime

Copy link

pytorch-bot bot commented Jan 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7561

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 4d86272 with merge base f370e78 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2025
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supporting dim order!

@cccclai cccclai added partner: mediatek Issues related to the Mediatek delegate topic: not user facing labels Jan 9, 2025
@cccclai
Copy link
Contributor

cccclai commented Jan 9, 2025

@digantdesai @Gasoonjia should we use this pass https://github.com/search?q=repo%3Apytorch%2Fexecutorch%20DimOrderOpsRevertPass&type=code instead of not partition?

@digantdesai - Yes, #4873 has more info. If you were lowering it before, which seems to be the case here, then you might also want to lower the dim_order variant of the same target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: mediatek Issues related to the Mediatek delegate topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants