-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dim order assert #7561
base: main
Are you sure you want to change the base?
Add dim order assert #7561
Conversation
neuropilot-captain
commented
Jan 9, 2025
- Add assert to AOT and runtime
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7561
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 4d86272 with merge base f370e78 (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for supporting dim order!
@digantdesai @Gasoonjia should we use this pass https://github.com/search?q=repo%3Apytorch%2Fexecutorch%20DimOrderOpsRevertPass&type=code instead of not partition? @digantdesai - Yes, #4873 has more info. If you were lowering it before, which seems to be the case here, then you might also want to lower the dim_order variant of the same target. |