Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of Method::init #7608

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 10, 2025

Stack from ghstack (oldest at bottom):

Apply the same technique as #7603 to Method::init

Differential Revision: D68041869

Apply the same technique as #7603 to Method::init

Differential Revision: [D68041869](https://our.internmc.facebook.com/intern/diff/D68041869/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jan 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7608

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b525fd9 with merge base e1c0bcf (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2025
swolchok pushed a commit that referenced this pull request Jan 10, 2025
Apply the same technique as #7603 to Method::init

Differential Revision: [D68041869](https://our.internmc.facebook.com/intern/diff/D68041869/)

ghstack-source-id: 260974726
Pull Request resolved: #7608
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68041869

@swolchok swolchok added the release notes: runtime Changes related to the core runtime which loads the program methods, initializes delegates, and runs label Jan 10, 2025
@swolchok swolchok requested review from dbort and lucylq January 10, 2025 23:40
Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@facebook-github-bot facebook-github-bot merged commit 56911f2 into gh/swolchok/130/base Jan 13, 2025
46 of 49 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/130/head branch January 13, 2025 18:05
kirklandsign pushed a commit that referenced this pull request Jan 21, 2025
Apply the same technique as #7603 to Method::init

Differential Revision: [D68041869](https://our.internmc.facebook.com/intern/diff/D68041869/)

ghstack-source-id: 260974726
Pull Request resolved: #7608

Co-authored-by: Github Executorch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: runtime Changes related to the core runtime which loads the program methods, initializes delegates, and runs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants