Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[executorch][core] NamedDataMap interface #7763

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Jan 18, 2025

Stack from ghstack (oldest at bottom):

Add NamedDataMap interface to runtime.

Differential Revision: D66834552

Add NamedDataMap interface to runtime.

Differential Revision: [D66834552](https://our.internmc.facebook.com/intern/diff/D66834552/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jan 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7763

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3fd73a1 with merge base 57ef834 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2025
lucylq added a commit that referenced this pull request Jan 18, 2025
Add NamedDataMap interface to runtime.

Differential Revision: [D66834552](https://our.internmc.facebook.com/intern/diff/D66834552/)

ghstack-source-id: 262004901
Pull Request resolved: #7763
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66834552

runtime/core/named_data_map.h Outdated Show resolved Hide resolved
runtime/core/named_data_map.h Outdated Show resolved Hide resolved
runtime/core/named_data_map.h Outdated Show resolved Hide resolved
runtime/core/named_data_map.h Outdated Show resolved Hide resolved
Add NamedDataMap interface to runtime.

Differential Revision: [D66834552](https://our.internmc.facebook.com/intern/diff/D66834552/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66834552

lucylq added a commit that referenced this pull request Jan 23, 2025
Pull Request resolved: #7763

Add NamedDataMap interface to runtime.
ghstack-source-id: 262734131
@exported-using-ghexport

Differential Revision: [D66834552](https://our.internmc.facebook.com/intern/diff/D66834552/)
@lucylq lucylq requested review from JacobSzwejbka and dbort January 23, 2025 18:39
@lucylq lucylq added release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) and removed topic: not user facing labels Jan 23, 2025
Add NamedDataMap interface to runtime.

Differential Revision: [D66834552](https://our.internmc.facebook.com/intern/diff/D66834552/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66834552

lucylq added a commit that referenced this pull request Jan 23, 2025
Pull Request resolved: #7763

Add NamedDataMap interface to runtime.
ghstack-source-id: 262787385
@exported-using-ghexport

Differential Revision: [D66834552](https://our.internmc.facebook.com/intern/diff/D66834552/)
@lucylq lucylq requested a review from JacobSzwejbka January 23, 2025 22:10
Add NamedDataMap interface to runtime.

Differential Revision: [D66834552](https://our.internmc.facebook.com/intern/diff/D66834552/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66834552

Copy link
Contributor

@dbort dbort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

runtime/core/named_data_map.h Outdated Show resolved Hide resolved
runtime/core/named_data_map.h Outdated Show resolved Hide resolved
runtime/core/named_data_map.h Outdated Show resolved Hide resolved
runtime/core/named_data_map.h Outdated Show resolved Hide resolved
runtime/core/named_data_map.h Outdated Show resolved Hide resolved
runtime/core/named_data_map.h Outdated Show resolved Hide resolved
Add NamedDataMap interface to runtime.

Differential Revision: [D66834552](https://our.internmc.facebook.com/intern/diff/D66834552/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Jan 24, 2025
Pull Request resolved: #7763

Add NamedDataMap interface to runtime.
ghstack-source-id: 262825121
@exported-using-ghexport

Differential Revision: [D66834552](https://our.internmc.facebook.com/intern/diff/D66834552/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66834552

@lucylq lucylq requested a review from dbort January 24, 2025 17:12
Copy link
Contributor

@dbort dbort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final minor things but this looks good!

runtime/core/named_data_map.h Outdated Show resolved Hide resolved
runtime/core/named_data_map.h Outdated Show resolved Hide resolved
runtime/core/named_data_map.h Show resolved Hide resolved
Add NamedDataMap interface to runtime.

Differential Revision: [D66834552](https://our.internmc.facebook.com/intern/diff/D66834552/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Jan 24, 2025
Pull Request resolved: #7763

Add NamedDataMap interface to runtime.
ghstack-source-id: 262955668
@exported-using-ghexport

Differential Revision: [D66834552](https://our.internmc.facebook.com/intern/diff/D66834552/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66834552

@facebook-github-bot facebook-github-bot merged commit 5dd16b1 into gh/lucylq/29/base Jan 24, 2025
47 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/lucylq/29/head branch January 24, 2025 23:16
kirklandsign pushed a commit that referenced this pull request Jan 24, 2025
Pull Request resolved: #7763

Add NamedDataMap interface to runtime.
ghstack-source-id: 262955668
@exported-using-ghexport

Differential Revision: [D66834552](https://our.internmc.facebook.com/intern/diff/D66834552/)

Co-authored-by: lucylq <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants