Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump PyTorch nightly to 20250131 #8098

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

bump PyTorch nightly to 20250131 #8098

wants to merge 7 commits into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 31, 2025 •
edited
Loading

No description provided.

@swolchok
Update
acedd13 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 31, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8098

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 444dd52 with merge base 6b58e2e (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 31, 2025
swolchok added a commit that referenced this pull request Jan 31, 2025
@swolchok
bump PyTorch nightly to 20250131
db188a5 
ghstack-source-id: cd34ac490ffcb39c02375b39e19ccaadc627b4d0
ghstack-comment-id: 2627845968
Pull Request resolved: #8098
@swolchok swolchok requested review from dbort and mergennachin and removed request for dbort January 31, 2025 17:18
@swolchok
Copy link
Contributor Author

looks like PyTorch changed how it finds OpenMP on Mac: pytorch/pytorch#145870, pytorch/pytorch#145889 (CC @malfet)

@swolchok
Update
9700e72 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 31, 2025
@swolchok
bump PyTorch nightly to 20250131
b03fa38 
ghstack-source-id: 87d7b37794cbc6452c2a0da27a518f4c7588bc91
ghstack-comment-id: 2627845968
Pull Request resolved: #8098
@swolchok
Update
35d1fb4 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 31, 2025
@swolchok
bump PyTorch nightly to 20250131
569b748 
ghstack-source-id: 95c1e018850e3cfe07772918e5150a6bd70d3df3
ghstack-comment-id: 2627845968
Pull Request resolved: #8098
@swolchok
Copy link
Contributor Author

let's try just installing libomp via brew? dogscience

@swolchok
Update
822f235 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 31, 2025
@swolchok
bump PyTorch nightly to 20250131
0217011 
ghstack-source-id: fe44e772e3b6afa56d2f7541c0baf6faed0df10f
ghstack-comment-id: 2627845968
Pull Request resolved: #8098
@swolchok
Update
789b271 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 3, 2025
@swolchok
bump PyTorch nightly to 20250131
fa3fb2a 
ghstack-source-id: c4941b5c8323ee019ef4806fbce86503fcd1e44b
ghstack-comment-id: 2627845968
Pull Request resolved: #8098
@mergennachin mergennachin requested a review from huydhn February 3, 2025 16:37
@mergennachin
Copy link
Contributor

@huydhn is this the right way to install libomp?

@swolchok
Copy link
Contributor Author

swolchok commented Feb 3, 2025 •
edited
Loading

collecting failures:

huydhn
huydhn reviewed Feb 3, 2025
View reviewed changes
.ci/docker/conda-env-ci.txt
@@ -1,4 +1,5 @@
cmake=3.22.1
ninja=1.10.2
libuv
llvm-openmp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one needed given that there is this line to install libomp here https://github.com/pytorch/executorch/blob/main/.ci/docker/common/install_clang.sh#L16?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC @malfet told me to add this one

huydhn
huydhn reviewed Feb 3, 2025
View reviewed changes
.ci/scripts/setup-macos.sh
@@ -121,6 +121,7 @@ setup_macos_env_variables
# NB: we need buck2 in all cases because cmake build also depends on calling
# buck2 atm
install_buck
brew install libomp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok, PyTorch is doing the same thing on MacOS.

@swolchok
Copy link
Contributor Author

swolchok commented Feb 3, 2025

unittest-arm failure seems to be caused by https://github.com/pytorch/pytorch/pull/145939/files#r1939935947 . I'm not familiar with the gritty details of Python importing and exporting so I don't know how to work around this issue. Anybody know?

@swolchok
Copy link
Contributor Author

swolchok commented Feb 3, 2025

unittest-arm failure seems to be caused by https://github.com/pytorch/pytorch/pull/145939/files#r1939935947 . I'm not familiar with the gritty details of Python importing and exporting so I don't know how to work around this issue. Anybody know?

got a fix in reply on that PR

@swolchok
Update
5f9e0d3 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 3, 2025
@swolchok
bump PyTorch nightly to 20250131
185fe83 
ghstack-source-id: de27be5e3d900b7cd2dd7fb4b64a24dad5eaea9e
ghstack-comment-id: 2627845968
Pull Request resolved: #8098
@swolchok
Copy link
Contributor Author

swolchok commented Feb 4, 2025

verified that the remaining unittest-arm failure is actually due to an improvement in the generated code: https://gist.github.com/swolchok/8719569204620d04059c8d8bf10b311d

@swolchok
Update
444dd52 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Feb 4, 2025
@swolchok
bump PyTorch nightly to 20250131
c1c1e92 
ghstack-source-id: 72ace0daecd506cc6beca30904a77218a965f8c0
ghstack-comment-id: 2627845968
Pull Request resolved: #8098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn left review comments

@mergennachin mergennachin mergennachin approved these changes

@digantdesai digantdesai digantdesai approved these changes

@dbort dbort Awaiting requested review from dbort

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@swolchok @mergennachin @digantdesai @huydhn @facebook-github-bot