Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump numpy from 1.19.3 to 1.22.0 in /requirements #2437

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 29, 2023

Bumps numpy from 1.19.3 to 1.22.0.

Release notes

Sourced from numpy's releases.

v1.22.0

NumPy 1.22.0 Release Notes

NumPy 1.22.0 is a big release featuring the work of 153 contributors spread over 609 pull requests. There have been many improvements, highlights are:

  • Annotations of the main namespace are essentially complete. Upstream is a moving target, so there will likely be further improvements, but the major work is done. This is probably the most user visible enhancement in this release.
  • A preliminary version of the proposed Array-API is provided. This is a step in creating a standard collection of functions that can be used across application such as CuPy and JAX.
  • NumPy now has a DLPack backend. DLPack provides a common interchange format for array (tensor) data.
  • New methods for quantile, percentile, and related functions. The new methods provide a complete set of the methods commonly found in the literature.
  • A new configurable allocator for use by downstream projects.

These are in addition to the ongoing work to provide SIMD support for commonly used functions, improvements to F2PY, and better documentation.

The Python versions supported in this release are 3.8-3.10, Python 3.7 has been dropped. Note that 32 bit wheels are only provided for Python 3.8 and 3.9 on Windows, all other wheels are 64 bits on account of Ubuntu, Fedora, and other Linux distributions dropping 32 bit support. All 64 bit wheels are also linked with 64 bit integer OpenBLAS, which should fix the occasional problems encountered by folks using truly huge arrays.

Expired deprecations

Deprecated numeric style dtype strings have been removed

Using the strings "Bytes0", "Datetime64", "Str0", "Uint32", and "Uint64" as a dtype will now raise a TypeError.

(gh-19539)

Expired deprecations for loads, ndfromtxt, and mafromtxt in npyio

numpy.loads was deprecated in v1.15, with the recommendation that users use pickle.loads instead. ndfromtxt and mafromtxt were both deprecated in v1.17 - users should use numpy.genfromtxt instead with the appropriate value for the usemask parameter.

(gh-19615)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [numpy](https://github.com/numpy/numpy) from 1.19.3 to 1.22.0.
- [Release notes](https://github.com/numpy/numpy/releases)
- [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst)
- [Commits](numpy/numpy@v1.19.3...v1.22.0)

---
updated-dependencies:
- dependency-name: numpy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jun 29, 2023
@msaroufim msaroufim self-requested a review June 29, 2023 21:04
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #2437 (9b5ae00) into master (a6fd770) will not change coverage.
The diff coverage is n/a.

❗ Current head 9b5ae00 differs from pull request most recent head fb39081. Consider uploading reports for the commit fb39081 to get more accurate results

@@           Coverage Diff           @@
##           master    #2437   +/-   ##
=======================================
  Coverage   71.34%   71.34%           
=======================================
  Files          85       85           
  Lines        3905     3905           
  Branches       58       58           
=======================================
  Hits         2786     2786           
  Misses       1115     1115           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim requested a review from namannandan June 30, 2023 22:20
@@ -1,5 +1,5 @@
--extra-index-url https://pip.repos.neuron.amazonaws.com
numpy==1.21.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version of neuronx-cc requires numpy 1.21.6, so I believe we should retain this version.
neuronx-cc 2.7.0.40+f7c6cf2a3 requires numpy<=1.21.6,>=1.20

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version of Neuronx-cc is 2.10.0.35 -- let's verify and work with Neuron team to upgrade the version

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version of neuronx-cc 2.11.0.34+c5231f848 requires numpy<=1.25.2,>=1.22.2. Will update the version here to fix this.

@msaroufim
Copy link
Member

@dependabot ignore this dependency

@msaroufim msaroufim closed this Jul 10, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 10, 2023

OK, I won't notify you about numpy again, unless you re-open this PR. 😢

@dependabot dependabot bot deleted the dependabot/pip/requirements/numpy-1.22.0 branch July 10, 2023 17:13
@msaroufim msaroufim restored the dependabot/pip/requirements/numpy-1.22.0 branch October 3, 2023 19:27
@msaroufim msaroufim reopened this Oct 3, 2023
@msaroufim msaroufim requested a review from namannandan October 3, 2023 19:35
@msaroufim msaroufim dismissed namannandan’s stale review October 3, 2023 19:35

naman could you please take a look at this again?

@@ -2,4 +2,4 @@ cython==0.29.34
wheel==0.40.0
pillow==9.3.0
numpy==1.24.3; sys_platform != 'win32'
numpy==1.19.3; sys_platform == 'win32' #see https://tinyurl.com/y3dm3h86
numpy==1.22.0; sys_platform == 'win32' #see https://tinyurl.com/y3dm3h86
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if we can use >= instead and not have to pin the version

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retaining fix recommended by dependabot since we currently don't test windows in CI.

@namannandan namannandan added this pull request to the merge queue Nov 16, 2023
Merged via the queue into master with commit a00972b Nov 16, 2023
13 checks passed
@dependabot dependabot bot deleted the dependabot/pip/requirements/numpy-1.22.0 branch November 16, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants