Improve docker image UX and fix MNIST serving example #3382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need to run tail to prevent docker exit, and ensures that signals will be passed by shell to torchserve, allowing it to terminate gracefully. This change moves the tail call to be used only if not running in serve (default) mode, allowing docker exit, so that the container can be restarted by the orchestrator, instead of leaving a container that no longer runs a torchserve instance (this improves UX with Kubernetes).
This improves usability of out-of-box TorchServe docker image without having to create a custom image or set configuration as command line options.
The model API is disabled by default, so it must be enabled first, or the model needs to be registered in an alternative way.
|
Additionally, if the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve ease of use for the docker image and fix the MNIST serving example.
I haven't filed an issue, and this does not seem to be reported (or I missed it - sorry!).
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
I've tested the changes only manually, as they are very small.
Checklist: