add ability to view multiple focused log lines at once #4637
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
add buttons to rate logs Adds buttons hidden under a feature flag which gives us the ability to rate logs <img width="1444" alt="Screenshot 2023-10-11 at 4 55 55 PM" src="https://github.com/pytorch/test-infra/assets/13758638/76748be5-44f7-4e51-8e72-d781a96e9ba3"> <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at e97f54f</samp> This pull request adds the feature to annotate the log rating of a job in the `LogViewer` component. It introduces a new component `LogAnnotationToggle` that allows users to select an annotation and sends it to a new API handler `/api/log_annotation`. It also defines a new type `LogAnnotation` and stores the annotation data in a DynamoDB table. --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/4629). * #4637 * __->__ #4629 Co-authored-by: PaliC <>
|
If the lines look exactly the same (same line number) like in the examples, should we just dedup them and show only one? |
|
Ouch, I got |
| @@ -21,8 +21,8 @@ export interface JobData extends BasicJobData { | |||
| logUrl?: string; | |||
| durationS?: number; | |||
| queueTimeS?: number; | |||
| failureLine?: string; | |||
| failureLineNumber?: number; | |||
| failureLines?: string[]; | |||
There was a problem hiding this comment.
Is this a correct understanding that this is only a cosmetic change atm because the current log classifier will always return only one failure line? So this would be an array one just one string
There was a problem hiding this comment.
yep it's just cosmetic atm
| failureLine?: string; | ||
| failureLineNumber?: number; | ||
| failureLines?: string[]; | ||
| failureLineNumbers?: number[]; |
There was a problem hiding this comment.
I think we might want to consider updating RecentWorkflowsData as well for consistency. It also has a single failure_line string field.
For the context, this failure line field is pretty important because it now influences how Dr.CI and mergebot detects flaky failures (I search for similar failures using this field as the input)
A request I have for later is to make sure that the failures are sorted so that the last failure is at index 0 and the first failure is the last one in the list, thoughts?
There was a problem hiding this comment.
May be it's better to do this in a separate PR, as this one is pretty big already.
| AND ( | ||
| failed_checks_count > 0 | ||
| OR pending_checks_count > 0 | ||
| -- gets percentage of total force merges, force merges with failures, and force merges without failures (impatient) |
There was a problem hiding this comment.
Is this change expected? As I see lots of differences between them and the before version has more comments :)
There was a problem hiding this comment.
I think this just got updated, when I was updating everything in rockset. This should be fine.
Add view of multiple lines using rockset. Currently we just show the same error line (because there is only one in rockset). Currently, this is also hidden under a feature flag. <img width="915" alt="Screenshot 2023-10-13 at 2 28 46 PM" src="https://github.com/pytorch/test-infra/assets/13758638/4652e132-6886-4c21-9ac4-f208cc4d1edd"> <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at a80550d</samp> This pull request adds the log annotation feature to the test-infra web app, which allows users to rate the quality of the log output for a job and to see multiple failure lines for a job. It also updates the backend SQL queries and the frontend components to handle the new failureLines and failureLineNumbers properties for jobs, and fixes some minor issues in the code. The affected files include `JobLinks.tsx`, `LogViewer.tsx`, `LogAnnotationToggle.tsx`, `types.ts`, `drciUtils.ts`, `searchUtils.ts`, `log_annotation/[repoOwner]/[repoName]/[annotation].ts`, `metrics.tsx`, and several files in the `rockset` folder.
This field is now called `failure_lines` after #4637, which allows it to capture multiple failures on the logs (from a new to-be-built log classifier). Here is the struct definition https://github.com/pytorch/test-infra/blob/main/torchci/lib/types.ts#L45
add ability to view multiple focused log lines at once
Add view of multiple lines using rockset. Currently we just show the same error line (because there is only one in rockset). Currently, this is also hidden under a feature flag.
🤖 Generated by Copilot at a80550d
This pull request adds the log annotation feature to the test-infra web app, which allows users to rate the quality of the log output for a job and to see multiple failure lines for a job. It also updates the backend SQL queries and the frontend components to handle the new failureLines and failureLineNumbers properties for jobs, and fixes some minor issues in the code. The affected files include
JobLinks.tsx,LogViewer.tsx,LogAnnotationToggle.tsx,types.ts,drciUtils.ts,searchUtils.ts,log_annotation/[repoOwner]/[repoName]/[annotation].ts,metrics.tsx, and several files in therocksetfolder.Stack created with Sapling. Best reviewed with ReviewStack.