Add Packer Build job for Windows AMI #6064
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
zxiiro
force-pushed
the
zxiiro/windows-ami-builder
branch
from
b5c22ad to
841f5b1
Compare
zxiiro
had a problem deploying
to
packer-build-env
GitHub Actions
Failure
zxiiro
had a problem deploying
to
packer-build-env
GitHub Actions
Failure
zxiiro
force-pushed
the
zxiiro/windows-ami-builder
branch
from
841f5b1 to
706494a
Compare
zxiiro
had a problem deploying
to
packer-build-env
GitHub Actions
Failure
zxiiro
force-pushed
the
zxiiro/windows-ami-builder
branch
from
706494a to
3f8191e
Compare
zxiiro
had a problem deploying
to
packer-build-env
GitHub Actions
Failure
Add a job to create Windows AMIs in the PyTorch AWS Account. Issue: #5992 Signed-off-by: Thanh Ha <[email protected]>
zxiiro
force-pushed
the
zxiiro/windows-ami-builder
branch
from
3f8191e to
1bfd5a1
Compare
zxiiro
had a problem deploying
to
packer-build-env
GitHub Actions
Failure
|
Hi @zxiiro this looks good. Would be nice to see it in action. |
@atalman You can see it in action here: https://github.com/pytorch/test-infra/actions/workflows/build-windows-ami.yml Since this PR is not yet merged we cannot use the WebUI to trigger it but I've been manually triggering it using the GitHub CLI.
One issue I've been having though with this PR is even though its successfully able to create the AMI. The packer command usually hangs at the very end either after it prints:
The job will fail and no AMI is created in this case. or when it prints:
The job will timeout and fail however when I check in AWS the AMI is there so this one passes despite the failure. I'm not sure why this happens. I've only see it successfully pass twice where everything was green. |
zxiiro
had a problem deploying
to
packer-build-env
GitHub Actions
Failure
Signed-off-by: Thanh Ha <[email protected]>
zxiiro
had a problem deploying
to
packer-build-env
GitHub Actions
Failure
|
Upon further inspecting looks like the EBS volume snapshots are taking a very long time in AWS to create. I wonder if we can tell packer to not wait for AMI creation to complete and just end the job once it gets there since the EBS volume snapshots seem like it could be a background thing. |
I just saw the snapshots have completed and AMI state is now available yet the packer command is still hanging waiting for it to complete. |
|
I think we can likely proceed with merging this since this is a manually triggered job and it does everything we need it to do despite this kinda annoying packer hang. This gets us where we want to go and we can cancel the workflow after checking that the AMI is available in AWS. |
Add a job to create Windows AMIs in the PyTorch AWS Account.
Issue: #5992