train_ddp, process_group: fixes so CUDA works e2e #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProcessGroupBaby
This adds
get_future()
support toBabyWork
which is required for using ProcessGroupBaby with the torchft ddp integration.This uses a thread with an extra queue to handle future completions.
Notably this is partial support:
ProcessGroupBabyNCCL
Fixes so it actually uses NCCL instead of Gloo and updated unit test to pass.
Manager
Fixes so we always apply the state_dict from the main thread in a safe spot to avoid version counter errors.
Test plan:
run train_ddp.py on two GPUs