Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manager] fix address when binding to 0 #67

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[manager] fix address when binding to 0 #67

merged 1 commit into from
Jan 10, 2025

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Jan 10, 2025

This fixes the announced address when the manager binds to port 0. Previously we were announcing an address with port 0 which caused a connection error when restoring from checkpoint.

Test plan:

torchft_lighthouse --min_replicas 2 --join_timeout_ms 1000
CUDA_VISIBLE_DEVICES=0 TORCHFT_LIGHTHOUSE=http://localhost:29510 torchrun --master_port 29502 --nnodes 1 --nproc_per_node 1 --max-restarts 10 train_ddp.py
CUDA_VISIBLE_DEVICES=1 TORCHFT_LIGHTHOUSE=http://localhost:29510 torchrun --master_port 29501 --nnodes 1 --nproc_per_node 1 --max-restarts 10 train_ddp.py

@d4l3k d4l3k requested review from fegin, H-Huang and Jackmin801 January 10, 2025 21:04
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 10, 2025
Copy link
Member

@H-Huang H-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@d4l3k d4l3k merged commit 6b3665a into main Jan 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants