Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Distributed(Tensor Parallel) Inference Recipe #2245

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

acisseJZhong
Copy link
Contributor

@acisseJZhong acisseJZhong commented Jan 10, 2025

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses.

Changelog

What are the changes made in this PR?

  • Copied dev/generate_v2.py and added TP to the recipe. The main change is in __init__ and __setup__.
  • Added model distribute to parallel each module.
  • Generalize load_from_full_model_state_dict to general parallelism, not only FSDP.
  • Added distributed inference config for llama3 70B and 3.1 70B.
  • Fixed a few typos.

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented Jan 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2245

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit a318544 with merge base baae232 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2025
@acisseJZhong acisseJZhong changed the title [TP] Added Distributed Inference Recipe Added Distributed(Tensor Parallel) Inference Recipe Jan 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 47.05882% with 18 lines in your changes missing coverage. Please review.

Project coverage is 66.84%. Comparing base (baae232) to head (f7615a1).

Files with missing lines Patch % Lines
torchtune/modules/transformer.py 38.46% 8 Missing ⚠️
torchtune/modules/attention.py 53.33% 7 Missing ⚠️
torchtune/modules/feed_forward.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2245      +/-   ##
==========================================
+ Coverage   64.30%   66.84%   +2.53%     
==========================================
  Files         352      352              
  Lines       20566    20598      +32     
==========================================
+ Hits        13225    13768     +543     
+ Misses       7341     6830     -511     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acisseJZhong acisseJZhong requested review from RdoubleA, ebsmothers and joecummings and removed request for RdoubleA and ebsmothers January 10, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants