Skip to content

Commit

Permalink
upgrade pyre version in fbcode/torchx - batch 1
Browse files Browse the repository at this point in the history
Differential Revision: D60994060
  • Loading branch information
Pyre Bot Jr. authored and facebook-github-bot committed Aug 9, 2024
1 parent 86f4344 commit 8969f3e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
2 changes: 2 additions & 0 deletions torchx/examples/apps/tracker/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ def test(
for data, target in test_loader:
data, target = data.to(device), target.to(device)
output = model(data)
# pyre-fixme[58]: `+` is not supported for operand types `int` and
# `Union[bool, float, int]`.
test_loss += F.nll_loss(
output, target, reduction="sum"
).item() # sum up batch loss
Expand Down
4 changes: 3 additions & 1 deletion torchx/pipelines/kfp/adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ def component_spec_from_app(app: api.AppDef) -> Tuple[str, api.Role]:

role = app.roles[0]
assert (
role.num_replicas == 1
role.num_replicas
== 1
# pyre-fixme[16]: `AppDef` has no attribute `num_replicas`.
), f"KFP adapter only supports one replica, got {app.num_replicas}"

command = [role.entrypoint, *role.args]
Expand Down
2 changes: 2 additions & 0 deletions torchx/schedulers/aws_batch_scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,8 @@ def _stream_events(
startFromHead=True,
**args,
)
# pyre-fixme[66]: Exception handler type annotation `unknown` must
# extend BaseException.
except self._log_client.exceptions.ResourceNotFoundException:
return [] # noqa: B901
if response["nextForwardToken"] == next_token:
Expand Down

0 comments on commit 8969f3e

Please sign in to comment.