Upgrade fsspec and s3fs versions #783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50388544 |
Codecov Report
@@ Coverage Diff @@
## main #783 +/- ##
=======================================
Coverage 92.88% 92.88%
=======================================
Files 96 96
Lines 6099 6099
=======================================
Hits 5665 5665
Misses 434 434
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kiukchung
reviewed
Nov 2, 2023
dev-requirements.txt
Outdated
| @@ -5,7 +5,7 @@ boto3==1.24.59 | |||
| captum>=0.4.0 | |||
| docker | |||
| flake8==3.9.0 | |||
| fsspec[s3]==2023.1.0 | |||
There was a problem hiding this comment.
should be >= (just like requirements.txt) no?
alanhdu
force-pushed
the
export-D50388544
branch
from
ac79518 to
0bd0108
Compare
alanhdu
added a commit
to alanhdu/torchx
that referenced
this pull request
Dec 14, 2023
Summary: Need to update code for fsspec/filesystem_spec#1394. Reviewed By: stepanhruda Differential Revision: D50388544
|
This pull request was exported from Phabricator. Differential Revision: D50388544 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50388544 |
alanhdu
force-pushed
the
export-D50388544
branch
from
0bd0108 to
c3868c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Need to update code for fsspec/filesystem_spec#1394.
Reviewed By: stepanhruda
Differential Revision: D50388544