fixing k8s node types for trn1 instance types #792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we use
K8S_ITYPE
for multi-node job's instance_type for AWS resources, it has to match the official label or we get the following error withaws_batch_scheduler
:Intentionally not keeping an alias to previous labels, e.g.
aws_trn1.32xl
because torchx suggests the new one.Test plan:
Fixed unit tests