Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torchx][runner] Simplify Runner.close. #830

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

ttsugriy
Copy link
Contributor

there is no need to use item tuples since name is not used

Test plan:
pyre -l torchx/runner/api.py

there is no need to use item tuples since `name` is not used
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 24, 2024
@manav-a manav-a self-requested a review February 29, 2024 07:12
@facebook-github-bot
Copy link
Contributor

@manav-a has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@manav-a manav-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@yikaiMeta yikaiMeta merged commit e5cb668 into pytorch:main Mar 1, 2024
18 of 24 checks passed
@ttsugriy ttsugriy deleted the patch-1 branch March 2, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants