Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format in local_scheduler.py #841

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix format in local_scheduler.py #841

merged 1 commit into from
Mar 4, 2024

Conversation

yikaiMeta
Copy link
Contributor

apply patch.
On meta side the auto patch fails. So I have to manually apply patch here.

Test plan:

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2024
@yikaiMeta
Copy link
Contributor Author

The next time linter fails, we should be careful as this could mean the format is wrong. And once it's landed, diff train might be broken.

@yikaiMeta yikaiMeta changed the title Update local_scheduler.py Fix format in local_scheduler.py Mar 4, 2024
@manav-a manav-a self-requested a review March 4, 2024 17:05
Copy link
Contributor

@manav-a manav-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@manav-a manav-a merged commit b1e4db5 into main Mar 4, 2024
18 of 22 checks passed
@manav-a manav-a deleted the yikaiMeta-patch-6 branch March 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants