Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add aws_p5en.48xlarge #995

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add aws_p5en.48xlarge #995

wants to merge 1 commit into from

Conversation

clumsy
Copy link
Contributor

@clumsy clumsy commented Dec 27, 2024

Adding a new AWS GPU-enabled instance type: aws_p5en.48xlarge
See the details and spec in https://aws.amazon.com/ec2/instance-types/p5

Test plan:
[x] unit test added
[x] submitted AWS Batch job

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 27, 2024
@clumsy
Copy link
Contributor Author

clumsy commented Dec 27, 2024 •
edited
Loading

@d4l3k please check if you can

tonykao8080
tonykao8080 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@tonykao8080 tonykao8080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonykao8080 tonykao8080 tonykao8080 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clumsy @tonykao8080 @facebook-github-bot @azzhipa