Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VIIRS EDR datasets #3044

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Jan 30, 2025

I got some test data, so tested what VIIRS EDR datasets can be added simply by configuration updates.

So here they are:

  • CloudBase
  • CloudDCOMP
  • CloudNCOMP
  • CloudLayers
  • CloudPhase
  • IceConcentration
  • IceAge

VolcanicAsh product requires code changes, so I'll create another PR for that when I get to it.

@pnuu pnuu added enhancement code enhancements, features, improvements component:readers labels Jan 30, 2025
@pnuu pnuu self-assigned this Jan 30, 2025
@pnuu pnuu requested review from djhoese and mraspaud as code owners January 30, 2025 08:15
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (01237e2) to head (0a734ba).
Report is 53 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3044   +/-   ##
=======================================
  Coverage   96.11%   96.11%           
=======================================
  Files         383      383           
  Lines       55673    55673           
=======================================
  Hits        53511    53511           
  Misses       2162     2162           
Flag Coverage Δ
behaviourtests 3.89% <ø> (ø)
unittests 96.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jan 30, 2025

Pull Request Test Coverage Report for Build 13055732724

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 96.222%

Files with Coverage Reduction New Missed Lines %
satpy/readers/satpy_cf_nc.py 1 99.1%
Totals Coverage Status
Change from base Build 12905542942: 0.0%
Covered Lines: 53758
Relevant Lines: 55869

💛 - Coveralls

@djhoese
Copy link
Member

djhoese commented Jan 30, 2025

Docs are failing with:

/home/docs/checkouts/readthedocs.org/user_builds/satpy/conda/3044/lib/python3.11/site-packages/satpy/readers/satpy_cf_nc.py:docstring of satpy.readers.satpy_cf_nc:79: WARNING: duplicate label api/satpy.readers.satpy_cf_nc:example:, other instance in /home/docs/checkouts/readthedocs.org/user_builds/satpy/checkouts/3044/doc/source/api/satpy.readers.satpy_cf_nc.rst [autosectionlabel.api/satpy.readers.satpy_cf_nc]

Not sure why that is showing up now.

There was also a message:

/home/docs/checkouts/readthedocs.org/user_builds/satpy/conda/3044/lib/python3.11/site-packages/dask/dataframe/__init__.py:49: FutureWarning: 
Dask dataframe query planning is disabled because dask-expr is not installed.

You can install it with `pip install dask[dataframe]` or `conda install dask`.
This will raise in a future version.

  warnings.warn(msg, FutureWarning)

But that isn't causing the failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants