Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom command to validate existing plugins on server #179

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sumandari
Copy link
Collaborator

@sumandari sumandari commented Apr 26, 2021

Please see #178

This PR to validate the existing plugins on server, which has been uploaded before the metadata validation function fixed.
Custom command will send email to the creator and author of invalid plugins.

@sumandari sumandari requested a review from dimasciput April 26, 2021 09:27
@sumandari sumandari self-assigned this Apr 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2021

Codecov Report

Merging #179 (23fea87) into master (222b10d) will increase coverage by 5.44%.
The diff coverage is 88.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   68.21%   73.66%   +5.44%     
==========================================
  Files         102      108       +6     
  Lines        3886     4162     +276     
==========================================
+ Hits         2651     3066     +415     
+ Misses       1235     1096     -139     
Impacted Files Coverage Δ
...s/management/commands/validate_existing_plugins.py 66.66% <66.66%> (ø)
qgis-app/plugins/views.py 30.07% <77.77%> (+11.46%) ⬆️
qgis-app/plugins/tests/test_views.py 89.55% <89.55%> (ø)
qgis-app/plugins/migrations/0002_plugininvalid.py 100.00% <100.00%> (ø)
qgis-app/plugins/models.py 81.31% <100.00%> (+20.12%) ⬆️
qgis-app/plugins/tests/model_factories.py 100.00% <100.00%> (ø)
qgis-app/plugins/tests/test_models.py 100.00% <100.00%> (ø)
...pp/plugins/tests/test_validate_existing_plugins.py 100.00% <100.00%> (ø)
qgis-app/plugins/urls.py 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222b10d...23fea87. Read the comment docs.

@sumandari sumandari requested a review from timlinux April 26, 2021 09:36
@timlinux
Copy link
Member

@sumandari I didnt look at the code, but it probably makes sense to only look at the latest version of each plugin - can you confirm if it does that?

@timlinux
Copy link
Member

Also it would be nice to have view or something of plugins whose latest version fails validation so that we can keep track of which ones are still problematic as fixes come in....

@sumandari sumandari marked this pull request as draft June 18, 2021 01:26
@sumandari sumandari force-pushed the 178_validate_existing_plugins branch from 2439750 to 53f67f0 Compare June 20, 2021 16:36
@sumandari
Copy link
Collaborator Author

178

@sumandari sumandari marked this pull request as ready for review July 23, 2021 10:22
@sumandari
Copy link
Collaborator Author

sumandari commented Jul 23, 2021

Once we run management command, it will create invalid plugin list.
When the plugin version updated and add new plugin version(with validation mechanism upon upload), it will be removed from invalid plugin list.

@timlinux
Copy link
Member

timlinux commented Aug 2, 2021

LGTM thanks @sumandari !

@dimasciput
Copy link
Collaborator

@Xpirix could you check if this is still useful?

@Xpirix
Copy link
Collaborator

Xpirix commented Jan 6, 2025

@dimasciput , we didn't receive any issues similar to #177 recently. This PR will list all the plugins that are uploaded before the metadata validation and didn't have new versions since. I can check locally to see how many plugins are invalid.

@Xpirix Xpirix added the 🕔 Size 2 Give me 2 hours and I will have it for you label Jan 13, 2025
@Xpirix
Copy link
Collaborator

Xpirix commented Jan 14, 2025

@dimasciput @timlinux

After checking locally, I think it's still useful to have the list of invalid plugins because the validation workflow has changed over time so we will also be able to see others that don't meet the current requirements (plugins that don't have a license file for example).

However, I have a few questions:

  • Some of the plugins are no longer maintained (the latest versions were uploaded 10 years ago and support for QGIS < 2.0) and are not marked as deprecated yet (https://plugins.qgis.org/plugins/FastSQL/ for example). Looking at the Github repo, it seems that the author doesn't have the time resources to maintain it anymore. So I wanted to ask if we could add to the email a section that (1) encourages the author to upload a new version that matches the current requirements, (2) notifies the author that the plugin will automatically be marked as deprecated if no new version is uploaded after X months,
  • Could apply the above suggestion for invalid plugins that don't have new versions after X years old, and/or don't have support for QGIS > X.XX ?
  • Could we implement this feature after the migration to the new branding? So we don't have to do it twice (here and on the new repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕔 Size 2 Give me 2 hours and I will have it for you
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

5 participants