Plugin resolved email #504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is the correct behavior.
That is also true. You do not want to spam all the users with notifications, and only the reviewer who initially reviewed the plugin should receive them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #503
Plugin <plugin_name> feedback resolved by <author>. Link: <plugin_version_feedback_link>. The plugin is now ready for review again.@NyakudyaA
A plugin will only move to the
Reviewed Plugins (Resolved)list when all items are checked. So I think, it would be more accurate to send the email when it's the case. What do you think?Also, do you think we need to notify all the staff users when the feedback items are resolved? My suggestion here is to send the email to the reviewers only. Any staff user can still see it under the Reviewed Plugins (Resolved) list.