Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOLDEV-1003 add optional testing of latest CKAN master #126

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

ThrawnCA
Copy link
Contributor

Add a test run on the latest upstream CKAN master, with success being optional (and tests currently fail), just so we have visibility.

- Run tests on latest CKAN master branch for visibility, but don't require success
- We want to see entire dicts on failure
@ThrawnCA ThrawnCA requested a review from a team November 11, 2024 23:45
@duttonw
Copy link
Member

duttonw commented Nov 12, 2024

hmm, master showing green even with test failures which are not surfaced is a bit :/

=========================== short test summary info ============================
FAILED ckanext/s3filestore/tests/test_controller.py::TestS3Controller::test_resource_show_url - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_controller.py::TestS3Controller::test_resource_download_s3 - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_controller.py::TestS3Controller::test_resource_download_wrong_filename - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_controller.py::TestS3Controller::test_resource_download_s3_no_filename - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_controller.py::TestS3Controller::test_resource_download_url_link - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_controller.py::TestS3Controller::test_resource_download_url - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_controller.py::TestS3Controller::test_resource_download_no_filename - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_controller.py::TestS3Controller::test_s3_resource_mimetype - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_controller.py::TestS3Controller::test_resource_download - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_controller.py::TestS3Controller::test_s3_download_link - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_resource_upload - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_package_update - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_uploader_get_path - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_resource_url_unsigned_for_public_dataset - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_resource_url_signed_for_private_dataset - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_making_dataset_private_updates_object_visibility - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_making_dataset_public_updates_object_visibility - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_non_current_objects_are_private - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_non_current_objects_match_acl - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_non_current_objects_match_auto_acl - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_delete_non_current_objects_after_expiry - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_do_not_delete_non_current_objects_before_expiry - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_assembling_object_metadata_headers - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_encoding_object_metadata_headers - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_ignoring_non_uploads - KeyError: 'id'
FAILED ckanext/s3filestore/tests/test_uploader.py::TestS3ResourceUploader::test_detect_office_document_type - KeyError: 'id'
================= 26 failed, 14 passed, 213 warnings in 46.22s =================
Error: Process completed with exit code 1.

@duttonw
Copy link
Member

duttonw commented Nov 12, 2024

i believe we need a way to get the details out if it did 'fail'

can you put --junitxml=test-results/results.xml or similar to get an xml version of the tests results

https://github.com/test-summary/action

i.e.

  • name: Test Summary
    if: always()
    uses: test-summary/action@v2
    with:
    paths: "test-results/results.xml"

@ThrawnCA ThrawnCA force-pushed the QOLDEV-1003-ckan-2.11 branch from 27e63cf to efb34a1 Compare November 12, 2024 06:48
@ThrawnCA
Copy link
Contributor Author

i believe we need a way to get the details out if it did 'fail'

How does https://github.com/qld-gov-au/ckanext-s3filestore/actions/runs/11792145642 look?

- Assume that resources with no ID are new and therefore don't need a visibility update,
since they would have been created with the matching visibility.
@duttonw
Copy link
Member

duttonw commented Nov 12, 2024

i believe we need a way to get the details out if it did 'fail'

How does https://github.com/qld-gov-au/ckanext-s3filestore/actions/runs/11792145642 look?

:D

@ThrawnCA ThrawnCA merged commit 0626404 into develop Nov 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants