Add more layout for skiller_sgk50_s4

[itarze]

Description

Add more layout for skiller_sgk50_s4

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[itarze]

If review is OK, please merge as soon as possible, thanks.

[itarze]

@waffle87 Does this PR need to wait until the next Breaking Changes to be merged? Should it be merged into the develop branch? Looking forward to your reply, thank you.

[fauxpark]

LAYOUT_all has overlapping keys.

[itarze]

@fauxpark This is due to the conflict between UK and US layouts. I’m not sure how to modify it. Could you assist me?

[fauxpark]

Are there two different PCBs for ANSI and ISO then? I would not expect, for example, the backspace area to consist of three separate matrix positions - usually one of them for the "split" backspace is wired to the 2u switch as well:

If so then this board should be split up into two revisions. That might be what needs to happen regardless.

[itarze]

@fauxpark The UK and US are on the same PCB.

[itarze]

@fauxpark Do you mean that this approach of combining multiple layouts on a single PCB cannot be merged?

[fauxpark]

Not if there are overlapping keys. LAYOUT_all isn't recommended for use in the default keymap; it's meant to expose all possible matrix positions, regardless of whether it is physically possible. So you can either adjust the layout to eliminate overlap (in the backspace example, perhaps by changing the widths to 0.5u-1u-0.5u), or split up the board into ANSI and ISO variants.

[itarze]

@fauxpark please review it again. Thanks.

[fauxpark]

LAYOUT_all still needs to be adjusted, as I mentioned above, or the board split into two revisions.

[itarze]

@fauxpark I have made the changes; please take another look.

[fauxpark]

Now there are no overlapping keys, but only because you've removed them. So they either never existed in the first place or you have misunderstood what I told you to do.

[itarze]

@fauxpark I’ve made further changes. Is it okay now?

[fauxpark]

Left Shift area still overlapping.

[itarze]

@fauxpark Has been modified.

[fauxpark]

0.25u is maybe a little too small.

[itarze]

Where can I find the images of this layout? It would help me make adjustments on my own.

[fauxpark]

You can hit Ctrl+Shift+I in the Configurator to load the keyboard.json for previewing the layout. Note that this does not allow you to compile the board, it's a developer tool only.

[itarze]

You can hit Ctrl+Shift+I in the Configurator to load the keyboard.json for previewing the layout. Note that this does not allow you to compile the board, it's a developer tool only.

I get it, Thanks. Is the current layout acceptable now?