Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyboard] mzmkb/slimdash/rev1 #24804

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

[keyboard] mzmkb/slimdash/rev1 #24804

wants to merge 26 commits into from

Conversation

mizma
Copy link

@mizma mizma commented Jan 9, 2025

Description

Add mzmkb/slimdash keyboard to QMK

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, are you planning on having multiple revisions of the board? If not, then the rev1 folder can/should be merged into the parent folder.

keyboards/mzmkb/slimdash/rev1/config.h Outdated Show resolved Hide resolved
keyboards/mzmkb/slimdash/rev1/keyboard.json Outdated Show resolved Hide resolved
keyboards/mzmkb/slimdash/rev1/keyboard.json Show resolved Hide resolved
keyboards/mzmkb/slimdash/rules.mk Outdated Show resolved Hide resolved
keyboards/mzmkb/slimdash/rev1/keyboard.json Outdated Show resolved Hide resolved
keyboards/mzmkb/slimdash/rev1/keyboard.json Outdated Show resolved Hide resolved
keyboards/mzmkb/slimdash/rev1/keyboard.json Outdated Show resolved Hide resolved
keyboards/mzmkb/slimdash/readme.md Outdated Show resolved Hide resolved
@mizma
Copy link
Author

mizma commented Jan 10, 2025

Also, are you planning on having multiple revisions of the board? If not, then the rev1 folder can/should be merged into the parent folder.

I am thinking of improving the design with a few more features I missed/omitted in the first design (possible scroll wheel, LED for CAPS etc.) I'm not sure if the firmware will/can be compatible yet since I have not planned out the wiring etc.

As for the suggested changes/review comments, I will go through them later on. Thank you.

@mizma mizma requested review from waffle87 and drashna January 10, 2025 07:08
@mizma
Copy link
Author

mizma commented Jan 10, 2025

checked all review comments and commited all changes.

built both the default and default_ortho_5x14 and confirmed to work without error (no build warns etc, flashed and tested keycodes in config.qmk.fm/#/test that all keys work as intended.

@mizma
Copy link
Author

mizma commented Jan 10, 2025

One question. I did add the suggestion to support ortho_5x14 layout, but the community layout doesn't seem to inted for a thumb cluster. using the default_ortho_5x14 build, I get keys like B and N in the far reaching thumb key intended for keys like ALT or CTRL. should I keep the community layout even though I think the default ortho_5x14 doesn't make sense for this keyboards physical layout?

@dunk2k
Copy link
Contributor

dunk2k commented Jan 10, 2025

One question. I did add the suggestion to support ortho_5x14 layout, but the community layout doesn't seem to inted for a thumb cluster. using the default_ortho_5x14 build, I get keys like B and N in the far reaching thumb key intended for keys like ALT or CTRL. should I keep the community layout even though I think the default ortho_5x14 doesn't make sense for this keyboards physical layout?

Just what i was thinking. Whilst I do see drashna's view that the physical layout of this board can somewhat be considered or fit into a ortho_5x14 Community Layout, the thumb cluster design does distinctly diverge the complete design from the Community Layout in question. In fairness, the diagrams in default/keymap.c are misleading.

I'd recommend (i.e. I'm not a QMK collaborator) that it would be better to revert back to LAYOUT layout macro. ortho_5x14 Community Layout is close but no cigar here, imo.

keyboards/mzmkb/slimdash/rev1/keyboard.json Outdated Show resolved Hide resolved
keyboards/mzmkb/slimdash/rev1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/mzmkb/slimdash/rev1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/mzmkb/slimdash/rev1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/mzmkb/slimdash/rev1/keymaps/default/keymap.c Outdated Show resolved Hide resolved
mizma and others added 2 commits January 10, 2025 22:57
Since although the logical matrix layout is akin to ortho_5x14, the physical layout is not compatible with the community ortho_5x14 layout, and cannot find any other appropriate layouts, we will revert to standard LAYOUT macro instead.

Co-authored-by: Duncan Sutherland <[email protected]>
@mizma mizma requested a review from dunk2k January 10, 2025 14:03
keyboards/mzmkb/slimdash/readme.md Outdated Show resolved Hide resolved
PCB image removed since the imgur service refuses to put it public.
@mizma mizma requested review from drashna and fauxpark January 12, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants