-
-
Notifications
You must be signed in to change notification settings - Fork 40.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keyboard] mzmkb/slimdash/rev1 #24804
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, are you planning on having multiple revisions of the board? If not, then the rev1 folder can/should be merged into the parent folder.
I am thinking of improving the design with a few more features I missed/omitted in the first design (possible scroll wheel, LED for CAPS etc.) I'm not sure if the firmware will/can be compatible yet since I have not planned out the wiring etc. As for the suggested changes/review comments, I will go through them later on. Thank you. |
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: jack <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
checked all review comments and commited all changes. built both the default and default_ortho_5x14 and confirmed to work without error (no build warns etc, flashed and tested keycodes in config.qmk.fm/#/test that all keys work as intended. |
One question. I did add the suggestion to support ortho_5x14 layout, but the community layout doesn't seem to inted for a thumb cluster. using the default_ortho_5x14 build, I get keys like B and N in the far reaching thumb key intended for keys like ALT or CTRL. should I keep the community layout even though I think the default ortho_5x14 doesn't make sense for this keyboards physical layout? |
Just what i was thinking. Whilst I do see drashna's view that the physical layout of this board can somewhat be considered or fit into a I'd recommend (i.e. I'm not a QMK collaborator) that it would be better to revert back to |
Since although the logical matrix layout is akin to ortho_5x14, the physical layout is not compatible with the community ortho_5x14 layout, and cannot find any other appropriate layouts, we will revert to standard LAYOUT macro instead. Co-authored-by: Duncan Sutherland <[email protected]>
PCB image removed since the imgur service refuses to put it public.
Co-authored-by: Ryan <[email protected]>
Description
Add mzmkb/slimdash keyboard to QMK
Types of Changes
Issues Fixed or Closed by This PR
Checklist