-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global logging feature, deprecate the logging extension and move its functionality to the core extension #1102
Conversation
This is quite a major change. @shumonsharif @famod, would you like to express your opinion, whether this is a good idea? |
Any chance to review or (n)ack? |
Hi @ppalaga Overall, I think it's a great idea, and the PR looks great as well. Please feel free to merge it. Digging into this, I was left wondering a few things on logging, even though they may not be directly tied to the PR - some docs on the below may help others.
|
Thanks @shumonsharif , those are good ideas, I have filed #1107 |
@ppalaga first off, I finally answered you initial question: #270 (comment) One question: That |
No, because I forgot 😂. I can implement it if you find it useful?
Yes, with current impl, if you enable logging globally, you can still mute it for individual clients and services by passing |
3c0e443: Added |
Fix #270