Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jbang, picocli, github-api for NativeBuildReport to fix Report stage of daily runs #1488

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Jan 9, 2025

Upgrade jbang, picocli, github-api for NativeBuildReport to fix Report stage of daily runs.

Fixes InaccessibleObjectException when closing GH issue

Currently the daily run can't close the GH issue, throwing InaccessibleObjectException, see https://github.com/quarkusio/quarkus-quickstarts/actions/runs/12682565687/job/35350789820

I think the issue is connected with newer JDK being used as a base, I was able to replicate the error with JDK 21 locally.
Upgrading picocli and github-api solved the issue, I tried locally and the GH issue was properly closed - quarkusio/quarkus#6588 (comment)
I also updated jbang to the latest, that's also version I used locally.

java.io.UncheckedIOException: java.io.IOException: Failed to set the custom verb
	at Report.run(NativeBuildReport.java:88)
	at picocli.CommandLine.executeUserObject(CommandLine.java:1769)
	at picocli.CommandLine.access$900(CommandLine.java:145)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2150)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2144)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2108)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:1975)
	at picocli.CommandLine.execute(CommandLine.java:1904)
	at Report.main(NativeBuildReport.java:97)
Caused by: java.io.IOException: Failed to set the custom verb
	at org.kohsuke.github.Requester.setRequestMethod(Requester.java:759)
	at org.kohsuke.github.Requester.setupConnection(Requester.java:745)
	at org.kohsuke.github.Requester._to(Requester.java:388)
	at org.kohsuke.github.Requester.to(Requester.java:336)
	at org.kohsuke.github.GHIssue.edit(GHIssue.java:239)
	at org.kohsuke.github.GHIssue.close(GHIssue.java:253)
	at Report.run(NativeBuildReport.java:71)
	... 8 more
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field protected java.lang.String java.net.HttpURLConnection.method accessible: module java.base does not "opens java.net" to unnamed module @6a463b3d
	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
	at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
	at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
	at java.base/java.lang.reflect.Field.setAccessible(Field.java:172)
	at org.kohsuke.github.Requester.setRequestMethod(Requester.java:756)
	... 14 more

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

Fixes InaccessibleObjectException when closing GH issue
@rsvoboda rsvoboda requested a review from gsmet January 9, 2025 07:56
@rsvoboda rsvoboda changed the title Upgrade jbang, picocli, github-api for NativeBuildReport to fix Report stage of daily runs. Upgrade jbang, picocli, github-api for NativeBuildReport to fix Report stage of daily runs Jan 9, 2025
Copy link

quarkus-bot bot commented Jan 9, 2025

Status for workflow Pull Request Build - development

This is the status report for running Pull Request Build - development on commit 64aa4a8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit cd5834c into quarkusio:development Jan 9, 2025
2 checks passed
@gsmet
Copy link
Member

gsmet commented Jan 9, 2025

Ideally, we should have a GH Action for this, instead of running a script that we spread all over the place.

@gsmet
Copy link
Member

gsmet commented Jan 9, 2025

I also updated quarkusio/quarkus-ecosystem-ci#169 while at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants