Skip to content

Commit

Permalink
Merge pull request #45724 from rsvoboda/2025-01-20.cleanup
Browse files Browse the repository at this point in the history
Drop FAQ entry about non-existing modules, remove irrelevant mentions about Java 8
  • Loading branch information
gsmet authored Jan 20, 2025
2 parents b57a865 + 95a1be4 commit 26cbbdb
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 13 deletions.
4 changes: 0 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -882,10 +882,6 @@ This project is an open source project, please act responsibly, be nice, polite

See section `IDEA Setup` as there are different possible solutions described.

* IntelliJ does not recognize the project as a Java 17 project

In the Maven pane, uncheck the `include-jdk-misc` and `compile-java8-release-flag` profiles

* Build hangs with DevMojoIT running infinitely

```shell
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,7 @@ public class AvroOptions {

/**
* The createOptionalGetters parameter enables generating the getOptional...
* methods that return an Optional of the requested type. This works ONLY on
* Java 8+
* methods that return an Optional of the requested type.
*/
final boolean createOptionalGetters;

Expand All @@ -138,16 +137,15 @@ public class AvroOptions {

/**
* The gettersReturnOptional parameter enables generating get... methods that
* return an Optional of the requested type. This will replace the This works
* ONLY on Java 8+
* return an Optional of the requested type.
*/
final boolean gettersReturnOptional;

/**
* The optionalGettersForNullableFieldsOnly parameter works in conjunction with
* gettersReturnOptional option. If it is set, Optional getters will be
* generated only for fields that are nullable. If the field is mandatory,
* regular getter will be generated. This works ONLY on Java 8+.
* regular getter will be generated.
*/
final boolean optionalGettersForNullableFieldsOnly;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,7 @@ public abstract class PathTreeWithManifest implements PathTree {
List<Integer> list = (List<Integer>) v.getClass().getMethod(versionStr).invoke(v);
JAVA_VERSION = list.get(0);
} catch (Exception e) {
//version 8
throw new IllegalStateException(
"Failed to obtain the Java version from java.lang.Runtime, possibly it's Java 8 which is not supported anymore",
e);
throw new IllegalStateException("Failed to obtain the Java version from java.lang.Runtime", e);
}
}

Expand Down

0 comments on commit 26cbbdb

Please sign in to comment.