Skip to content

Commit

Permalink
docs: Apply review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Thomas Canava committed Jan 9, 2025
1 parent 019dd43 commit e24d597
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 32 deletions.
20 changes: 0 additions & 20 deletions docs/src/main/asciidoc/aws-lambda.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -286,27 +286,8 @@ for your lambda deployment.

Example Gradle dependencies:

[role="primary asciidoc-tabs-sync-groovy"]
.Groovy DSL
****
[source,groovy]
----
dependencies {
implementation enforcedPlatform("${quarkusPlatformGroupId}:${quarkusPlatformArtifactId}:${quarkusPlatformVersion}")
implementation 'io.quarkus:quarkus-resteasy'
implementation 'io.quarkus:quarkus-amazon-lambda'
testImplementation 'io.quarkus:quarkus-junit5'
testImplementation 'io.rest-assured:rest-assured'
}
----
****

[role="secondary asciidoc-tabs-sync-kotlin"]
.Kotlin DSL
****
[source,kotlin]
----
dependencies {
implementation(enforcedPlatform("${quarkusPlatformGroupId}:${quarkusPlatformArtifactId}:${quarkusPlatformVersion}"))
implementation("io.quarkus:quarkus-resteasy")
Expand All @@ -316,7 +297,6 @@ dependencies {
testImplementation("io.rest-assured:rest-assured")
}
----
****


== Live Coding and Unit/Integration Testing
Expand Down
24 changes: 12 additions & 12 deletions docs/src/main/asciidoc/building-my-first-extension.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -427,10 +427,10 @@ include 'runtime', 'deployment' <2>
rootProject.name = 'greeting-extension'
----
****

<1> Configure the quarkus extension plugin version
<2> Include both `runtime` and `deployment` modules
****


[role="secondary asciidoc-tabs-sync-kotlin"]
.Kotlin DSL
Expand All @@ -451,10 +451,10 @@ include("runtime", "deployment") <2>
rootProject.name = "greeting-extension"
----
****

<1> Configure the quarkus extension plugin version
<2> Include both `runtime` and `deployment` modules
****


NOTE: For kotlin add the `.kts` extension the build files, for example: `settings.gradle.kts`

Expand All @@ -473,11 +473,11 @@ subprojects {
version '1.0-SNAPSHOT'
}
----
****

<1> Apply the `java-library` plugin for all sub-modules
<2> Apply the `maven-publish` plugin used to publish our artifacts
<3> Globally set the group id used for publication
****


[role="secondary asciidoc-tabs-sync-kotlin"]
.Kotlin DSL
Expand All @@ -492,19 +492,19 @@ subprojects {
version = "1.0-SNAPSHOT"
}
----
****

<1> Apply the `java-library` plugin for all sub-modules
<2> Apply the `maven-publish` plugin used to publish our artifacts
<3> Globally set the group id used for publication
****


The `io.quarkus.extension` plugin will be used in order to help us building the extension.
The plugin will *only* be applied to the `runtime` module.

==== The deployment module

The deployment module does not require any specific plugin.
Here is an example of a minimal gradle build file for the `deployment` module:
Here is an example of a minimal Gradle build file for the `deployment` module:

[role="primary asciidoc-tabs-sync-groovy"]
.Groovy DSL
Expand All @@ -520,10 +520,10 @@ dependencies {
testImplementation 'io.quarkus:quarkus-junit5-internal'
}
----
****

<1> By convention, the deployment module has the `-deployment` suffix (`greeting-extension-deployment`).
<2> The deployment module *must* depend on the `runtime` module.
****


[role="secondary asciidoc-tabs-sync-kotlin"]
.Kotlin DSL
Expand All @@ -538,9 +538,9 @@ dependencies {
testImplementation("io.quarkus:quarkus-junit5-internal")
}
----
<1> The deployment module *must* depend on the `runtime` module.
****

<1> The deployment module *must* depend on the `runtime` module.

==== The runtime module

Expand Down

0 comments on commit e24d597

Please sign in to comment.