Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider enabling substitutions in Target_javax_net_ssl_SSLContext.java disabled because of JDK 8 #45739

Open
rsvoboda opened this issue Jan 21, 2025 · 2 comments · May be fixed by #45812
Open

Consider enabling substitutions in Target_javax_net_ssl_SSLContext.java disabled because of JDK 8 #45739

rsvoboda opened this issue Jan 21, 2025 · 2 comments · May be fixed by #45812
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements

Comments

@rsvoboda
Copy link
Member

Description

Consider enabling substitutions in Target_javax_net_ssl_SSLContext.java disabled because of JDK 8

https://github.com/quarkusio/quarkus/blob/main/core/runtime/src/main/java/io/quarkus/runtime/graal/Target_javax_net_ssl_SSLContext.java#L38

Comment says:

    //    TODO sun.security.jca.GetInstance is not accessible in JDK 11. We cannot add an export
    //    as we still compile with a JDK 8 target. So for now, we will have to leave with this
    //    and only override getDefault().

CC @gsmet

Implementation ideas

No response
@rsvoboda rsvoboda added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jan 21, 2025
@geoand
Copy link
Contributor

geoand commented Jan 22, 2025

I would try removing it if I were you and let CI run on my fork

@rsvoboda
Copy link
Member Author

Run on my fork went well, I will create PR with the drop of Target_javax_net_ssl_SSLContext

@rsvoboda rsvoboda linked a pull request Jan 23, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop Target_javax_net_ssl_SSLContext substitutions rsvoboda/quarkus
2 participants
@rsvoboda @geoand