Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Target_javax_net_ssl_SSLContext substitutions #45812

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rsvoboda
Copy link
Member

Drop Target_javax_net_ssl_SSLContext substitutions

Resolves #45739

@gsmet
Copy link
Member

gsmet commented Jan 23, 2025

CI will pass. Problem might be size of native executable when SSL is disabled.

I prepared a PR with hopefully the necessary changes but didn't have the time to finalize.

See https://quarkus.io/guides/native-and-ssl#lets-disable-ssl-and-see-how-it-goes .

If your patch doesn't make any difference in this case, then we can pursue.

@rsvoboda
Copy link
Member Author

Ok, I will look into that. From the original commit I though there were functional issues when quarkus.ssl.native=false was set - e.g. in 7ea698e#diff-90b1e30d9f494ec4747fd06e5bd4b6dabdaa0cfffc5fcf458e08c3e8baffb393R17

@rsvoboda rsvoboda marked this pull request as draft January 23, 2025 09:33
@rsvoboda
Copy link
Member Author

rsvoboda commented Jan 23, 2025

I did just quick check with 3.17.8 and the size of native is the same no matter what quarkus.ssl.native value is set

mvn -pl resteasy-client-quickstart clean verify -Dnative -Dquarkus.platform.version=3.17.8 -Dquarkus.ssl.native=true
ls -lh resteasy-client-quickstart/target/resteasy-client-quickstart-1.0.0-SNAPSHOT-runner
-rwxr-xr-x@ 1 rsvoboda  staff    59M Jan 23 12:49 resteasy-client-quickstart/target/resteasy-client-quickstart-1.0.0-SNAPSHOT-runner

mvn -pl resteasy-client-quickstart clean verify -Dnative -Dquarkus.platform.version=3.17.8 -Dquarkus.ssl.native=false
ls -lh resteasy-client-quickstart/target/resteasy-client-quickstart-1.0.0-SNAPSHOT-runner
-rwxr-xr-x@ 1 rsvoboda  staff    59M Jan 23 12:52 resteasy-client-quickstart/target/resteasy-client-quickstart-1.0.0-SNAPSHOT-runner

@rsvoboda
Copy link
Member Author

rsvoboda commented Jan 23, 2025

And I received Caused by: java.lang.IllegalArgumentException: https://stage.code.quarkus.io/api requires SSL support but it is disabled. You probably have set quarkus.ssl.native to false. when ssl was disabled (but the size was the same as when ssl was enabled)

@gsmet this feels like a bug, size should be smaller when ssl is disabled, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider enabling substitutions in Target_javax_net_ssl_SSLContext.java disabled because of JDK 8
2 participants