Bump io.smallrye.common:smallrye-common-bom from 2.3.0 to 2.4.0 #39974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
area/dependencies
quarkus-bot
bot
added
the
area/devtools
dmlloyd
approved these changes
Apr 9, 2024
|
Looks like native metrics again: |
This comment has been minimized.
This comment has been minimized.
|
@zakkak I think we should improve how the metrics are collected so that we are able to provide a diff of what's new. Otherwise it's very hard to take an informed decision. |
@gsmet I agree that it would help but it's not trivial without a database (ideas are welcome though). Please have a look at #40076, where I document our (mandrel team's) idea on how to tackle this, and share your thoughts. |
|
FWIW in this case it seems like the 1% threshold for JNI methods is just a bit tight... |
|
@dependabot recreate |
dependabot
bot
force-pushed
the
dependabot/maven/io.smallrye.common-smallrye-common-bom-2.4.0
branch
from
75639b2 to
6a033df
Compare
This comment has been minimized.
This comment has been minimized.
|
@dependabot recreate |
dependabot
bot
force-pushed
the
dependabot/maven/io.smallrye.common-smallrye-common-bom-2.4.0
branch
from
6a033df to
d584717
Compare
This comment has been minimized.
This comment has been minimized.
dependabot
bot
force-pushed
the
dependabot/maven/io.smallrye.common-smallrye-common-bom-2.4.0
branch
from
d584717 to
d775778
Compare
This comment has been minimized.
This comment has been minimized.
|
@dependabot recreate |
dependabot
bot
force-pushed
the
dependabot/maven/io.smallrye.common-smallrye-common-bom-2.4.0
branch
from
d775778 to
6ac7eae
Compare
This comment has been minimized.
This comment has been minimized.
|
@zakkak what should we do about this one, raise the threshold? |
gsmet
force-pushed
the
dependabot/maven/io.smallrye.common-smallrye-common-bom-2.4.0
branch
from
6ac7eae to
7c0fc88
Compare
quarkus-bot
bot
added
area/hibernate-orm
|
I rebased and updated the JNI metrics but will wait for @zakkak to confirm it's the way to go. |
This comment has been minimized.
This comment has been minimized.
|
Sounds like it still needs some love in the |
Hi there, sorry for the late reply, yes please feel free to bump the threshold (I am soon going to check if the new stats tracking is wokring as expected and drop these tests anyway) |
gsmet
force-pushed
the
dependabot/maven/io.smallrye.common-smallrye-common-bom-2.4.0
branch
from
7c0fc88 to
8b009ec
Compare
gsmet
added
the
triage/waiting-for-ci
gsmet
approved these changes
Jun 14, 2024
This comment has been minimized.
This comment has been minimized.
|
The failure now seems to have something to do with a socket timeout related to TLS: It only happened on Windows, so I'll try rerunning just that test to see if it's a transient problem. |
This comment has been minimized.
This comment has been minimized.
|
Same problem again. :( It looks like there could be a possible way for invalid URLs to be created on Windows, so at least one possible explanation would be that this is occurring and causing the class loading util methods to produce a wrong result. But it's hard to prove. I'll have to set up a specific reproducer on a Windows VM to figure it out (which I won't be able to do until next week). |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
Bumps [io.smallrye.common:smallrye-common-bom](https://github.com/smallrye/smallrye-common) from 2.3.0 to 2.4.0. - [Release notes](https://github.com/smallrye/smallrye-common/releases) - [Commits](smallrye/smallrye-common@2.3.0...2.4.0) --- updated-dependencies: - dependency-name: io.smallrye.common:smallrye-common-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/maven/io.smallrye.common-smallrye-common-bom-2.4.0
branch
from
8b009ec to
4837edd
Compare
|
At this point, we might as well wait for 2.5.0. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
quarkus-bot
bot
added
triage/invalid
dependabot
bot
deleted the
dependabot/maven/io.smallrye.common-smallrye-common-bom-2.4.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps io.smallrye.common:smallrye-common-bom from 2.3.0 to 2.4.0.
Release notes
Sourced from io.smallrye.common:smallrye-common-bom's releases.
Commits
19c70b0[maven-release-plugin] prepare release 2.4.03e0c7c7Merge pull request #301 from smallrye/release-2.4.0e6923b0Release 2.4.097c00f3Merge pull request #299 from dmlloyd/pid016ad93Do not cache PID or process name9a34989Merge pull request #293 from dmlloyd/jarfb9f6deMerge pull request #298 from smallrye/dependabot/maven/version.vertx-4.5.76f6620cBump version.vertx from 4.5.6 to 4.5.70cbda4dMerge pull request #296 from smallrye/dependabot/maven/version.vertx-4.5.60658a06Merge pull request #295 from smallrye/dependabot/maven/org.ow2.asm-asm-9.7You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)