Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS Registry: provide a TLS configuration called javax.net.ssl having truststore set in the same way as default SunJSSE provider #45184

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Dec 18, 2024

fix #45175

Copy link

quarkus-bot bot commented Dec 18, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@ppalaga ppalaga changed the title [TLS Registry] provide a TLS configuration called javax.net.ssl having truststore set in the same way as default SunJSSE provider TLS Registry: provide a TLS configuration called javax.net.ssl having truststore set in the same way as default SunJSSE provider Dec 18, 2024
@ppalaga
Copy link
Contributor Author

ppalaga commented Dec 18, 2024

Created as a draft, because the documentation is still missing.
The code is ready for review.

Copy link

github-actions bot commented Dec 18, 2024

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Dec 18, 2024
@ppalaga ppalaga marked this pull request as ready for review December 18, 2024 20:00
@ppalaga
Copy link
Contributor Author

ppalaga commented Dec 18, 2024

a4c5028: added some docs, now complete from my PoV.

This comment has been minimized.

This comment has been minimized.

@ppalaga
Copy link
Contributor Author

ppalaga commented Jan 10, 2025

Any chance to review, @cescoffier or anybody else?

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment in the test.

…g truststore set in the same way as default SunJSSE provider, fix quarkusio#45175
Copy link

quarkus-bot bot commented Jan 13, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit f2c37e6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@ppalaga
Copy link
Contributor Author

ppalaga commented Jan 13, 2025

f2c37e6:

Copy link

quarkus-bot bot commented Jan 13, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f2c37e6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/opentelemetry-quickstart

io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled(OpenTelemetryDisabledTest.java:29)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ Native Tests - Security2

📦 integration-tests/oidc-client-wiremock

io.quarkus.it.keycloak.OidcClientInGraalITCase.testGetAccessTokenWithConfiguredExpiresIn - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at io.quarkus.it.keycloak.OidcClientTest.testGetAccessTokenWithConfiguredExpiresIn(OidcClientTest.java:68)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:789)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@ppalaga
Copy link
Contributor Author

ppalaga commented Jan 17, 2025

Is there anything missing to merge?

@cescoffier
Copy link
Member

Nope, everything is fine

@cescoffier cescoffier merged commit 665c842 into quarkusio:main Jan 18, 2025
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 18, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jan 18, 2025
@ppalaga
Copy link
Contributor Author

ppalaga commented Jan 18, 2025

@gsmet would there be any chance to get this one to 3.18.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/docstyle issues related for manual docstyle review area/documentation kind/enhancement New feature or request triage/flaky-test
Projects
None yet
2 participants