-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure there are no jdbc spans if otel sdk is disabled #45359
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have to submit another commit on this PR. |
1f66fec
to
4c8d7b9
Compare
Updated the code and the PR description. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two comments.
Would like to get @yrodiere 's opinion too.
extensions/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/DataSources.java
Outdated
Show resolved
Hide resolved
extensions/agroal/deployment/src/main/java/io/quarkus/agroal/deployment/AgroalProcessor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have doubts about how config is retrieved, but if tests pass... LGTM.
extensions/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/DataSources.java
Outdated
Show resolved
Hide resolved
...-jdbc-instrumentation/src/test/java/io/quarkus/it/opentelemetry/MariaDbLifecycleManager.java
Show resolved
Hide resolved
4c8d7b9
to
2ba88e5
Compare
2ba88e5
to
860989d
Compare
This comment has been minimized.
This comment has been minimized.
860989d
to
0a2fcea
Compare
This comment has been minimized.
This comment has been minimized.
0a2fcea
to
a978058
Compare
Status for workflow
|
During the OTel performance work I noticed that the OTel jdbc wrapper was being run even if the OTel SDK was disabled at runtime.
The PR fixes the unnecessary execution of the span creation, therefore improving performance.
Also found that if the OTel extension was disabled at build time, quarkus would fail to start if the wrapper was present.
Could not create a test because
NoNettyDataSourceConfigTest
doesn't like the OTel extension.