Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionalize references to OAuth2 #45426

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Jan 7, 2025

Conditionalize references to OAuth2 in shared files.
@sberyozkin please review and approve.

Copy link

quarkus-bot bot commented Jan 7, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@rolfedh rolfedh requested a review from sberyozkin January 7, 2025 20:57
@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@sberyozkin
Copy link
Member

sberyozkin commented Jan 11, 2025

Hi Rolfe, please only remove a ref to OAuth2 in the identity providers section

@rolfedh rolfedh force-pushed the update-make-improvements branch from e4eb20c to 37062d0 Compare January 13, 2025 19:43
@rolfedh rolfedh requested a review from sberyozkin January 13, 2025 19:44
@rolfedh
Copy link
Contributor Author

rolfedh commented Jan 13, 2025

Thank you for your review, @sberyozkin. I've updated the PR based on your suggestions.
Rolfe

Copy link

quarkus-bot bot commented Jan 13, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 37062d0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rolfe

@sberyozkin sberyozkin merged commit 529a20d into quarkusio:main Jan 14, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants