Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to runtime initialization instead of rerun #45611

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Jan 15, 2025

They both have the same result starting with 23.1. Runtime
initialization is public API while rerun is not, and will soon be
deprecated and at some point removed in future releases.

See oracle/graal#5013 (comment)
and oracle/graal#8323

Keeping as draft until it's tested with both:

and

Closes #25975

@zakkak zakkak force-pushed the 2024-02-15-no-runtime-rerun branch from 7c480a8 to 5ac14e9 Compare January 15, 2025 12:53
They both have the same result starting with 23.1. Runtime
initialization is public API while rerun is not, and will soon be
deprecated and at some point removed in future releases.

See oracle/graal#5013 (comment)
and oracle/graal#8323
@zakkak zakkak force-pushed the 2024-02-15-no-runtime-rerun branch from 5ac14e9 to 4217cdb Compare January 15, 2025 13:21
This change does not have any impact in Mandrel/GraalVM for JDK 21 and
later versions, but allows Quarkus to build with Mandrel/GraalVM for JDK
17.
Starting with Mandrel/GraalVM for JDK 21
`RuntimeReinitializedClassBuildItem` is functionally the same with
`RuntimeInitializedClassBuildItem`.
@zakkak zakkak marked this pull request as ready for review January 16, 2025 07:31
@zakkak zakkak requested a review from geoand January 16, 2025 07:32
Copy link

quarkus-bot bot commented Jan 16, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 68c5071.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/opentelemetry-quickstart

io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest was not fulfilled within 200 milliseconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryDisabledTest.buildTimeDisabled(OpenTelemetryDisabledTest.java:29)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

@zakkak zakkak merged commit e4c8488 into quarkusio:main Jan 16, 2025
67 checks passed
@zakkak zakkak deleted the 2024-02-15-no-runtime-rerun branch January 16, 2025 13:56
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring the way we register classes for reflection, JNI, etc.
2 participants