Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started with Security updates #45646

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

sberyozkin
Copy link
Member

As Martin Ocenas rightly pointed out, the configuration advice is confusing, first we suggest using prod level DB properties without %prod which causes mvn quarkus:dev failure and then recommend using @prod. I've done minor updates to fix it, and also other minor updates recommended by Martin

Copy link

github-actions bot commented Jan 16, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sberyozkin sberyozkin force-pushed the getting_started_security_update branch from 366b286 to 9e79265 Compare January 16, 2025 15:06
@sberyozkin
Copy link
Member Author

Thanks @rolfedh, @gastaldi, please approve if it looks good to you as well

Copy link

quarkus-bot bot commented Jan 16, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 9e79265.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 7d0b8df into quarkusio:main Jan 16, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 16, 2025
@sberyozkin sberyozkin deleted the getting_started_security_update branch January 16, 2025 16:32
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.0 Jan 21, 2025
@gsmet gsmet modified the milestones: 3.18.0, 3.17.8 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants