Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document injecting of CDI request scoped beans during authentication and authorization #45656

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jan 16, 2025

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jan 16, 2025
@michalvavrik michalvavrik force-pushed the feature/security-authz-and-proactive-auth-docs-updates branch 2 times, most recently from fca775c to 5712409 Compare January 16, 2025 16:40
Copy link

github-actions bot commented Jan 16, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/security-authz-and-proactive-auth-docs-updates branch from 5712409 to 1fd3636 Compare January 16, 2025 19:32

This comment has been minimized.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalvavrik, let me also ask Rolfe to have a look since the Doc team is working with al of these documents in the product docs

@sberyozkin sberyozkin requested a review from rolfedh January 17, 2025 12:07
@michalvavrik michalvavrik force-pushed the feature/security-authz-and-proactive-auth-docs-updates branch from 1fd3636 to 1912206 Compare January 17, 2025 12:57

This comment has been minimized.

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I’ve offered some minor copyedits to enhance clarity.

@michalvavrik michalvavrik force-pushed the feature/security-authz-and-proactive-auth-docs-updates branch from 1912206 to 3c65082 Compare January 17, 2025 14:44
@michalvavrik
Copy link
Member Author

That was very helpful, thank you very much @rolfedh .

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/security-authz-and-proactive-auth-docs-updates branch from 3c65082 to a94d3ca Compare January 17, 2025 17:16
Copy link

quarkus-bot bot commented Jan 17, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit a94d3ca.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin sberyozkin merged commit aec3f34 into quarkusio:main Jan 17, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 17, 2025
@michalvavrik michalvavrik deleted the feature/security-authz-and-proactive-auth-docs-updates branch January 17, 2025 19:41

You may need to inject `@RequestScoped` beans during authentication and authorization.
A good example of this is accessing a database during a `SecurityIdentity` augmentation,
which is described in the xref:security-customization.adoc#security-identity-customization[Security Identity Customization] section of the "Security Tips and Tricks" guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michalvavrik,

Thank you for this excellent documentation—it’s really well done. Could I kindly ask that you avoid hard line breaks mid-sentence, like the one here? It can make searching for strings a bit more challenging. Thanks so much for your understanding!

Copy link
Member Author

@michalvavrik michalvavrik Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rolfedh . I do it because I don't like editing these long lines in IDE, but I can avoid it for sentences, that suggestion sounds OK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for understanding, @michalvavrik. I completely get where you’re coming from about editing long lines—they can be a hassle! Are you already using the soft wrap or word wrap feature in your IDE? It might make working with longer lines a bit easier. Let me know if I can help with anything else!

https://gist.github.com/luidgigromat/da7d751d06140008c3b2b7612b6b69c2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I didn't use that. Good idea, thank you.

@gsmet gsmet modified the milestones: 3.19 - main, 3.18.0 Jan 21, 2025
@gsmet gsmet modified the milestones: 3.18.0, 3.17.8 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants