-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document injecting of CDI request scoped beans during authentication and authorization #45656
Document injecting of CDI request scoped beans during authentication and authorization #45656
Conversation
michalvavrik
commented
Jan 16, 2025
•
edited
Loading
edited
- documents answer for the Is it possilbe to access UriInfo from a HttpSecurityPolicy? #45618
- documents relation between proactive authentication and CDI request context authentication because I have answered questions related to this too many time without taking action
fca775c
to
5712409
Compare
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
5712409
to
1fd3636
Compare
This comment has been minimized.
This comment has been minimized.
docs/src/main/asciidoc/security-authorize-web-endpoints-reference.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michalvavrik, let me also ask Rolfe to have a look since the Doc team is working with al of these documents in the product docs
1fd3636
to
1912206
Compare
This comment has been minimized.
This comment has been minimized.
docs/src/main/asciidoc/security-authorize-web-endpoints-reference.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I’ve offered some minor copyedits to enhance clarity.
docs/src/main/asciidoc/security-authorize-web-endpoints-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-authorize-web-endpoints-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-authorize-web-endpoints-reference.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-authorize-web-endpoints-reference.adoc
Outdated
Show resolved
Hide resolved
1912206
to
3c65082
Compare
That was very helpful, thank you very much @rolfedh . |
This comment has been minimized.
This comment has been minimized.
3c65082
to
a94d3ca
Compare
Status for workflow
|
|
||
You may need to inject `@RequestScoped` beans during authentication and authorization. | ||
A good example of this is accessing a database during a `SecurityIdentity` augmentation, | ||
which is described in the xref:security-customization.adoc#security-identity-customization[Security Identity Customization] section of the "Security Tips and Tricks" guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michalvavrik,
Thank you for this excellent documentation—it’s really well done. Could I kindly ask that you avoid hard line breaks mid-sentence, like the one here? It can make searching for strings a bit more challenging. Thanks so much for your understanding!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rolfedh . I do it because I don't like editing these long lines in IDE, but I can avoid it for sentences, that suggestion sounds OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for understanding, @michalvavrik. I completely get where you’re coming from about editing long lines—they can be a hassle! Are you already using the soft wrap or word wrap feature in your IDE? It might make working with longer lines a bit easier. Let me know if I can help with anything else!
https://gist.github.com/luidgigromat/da7d751d06140008c3b2b7612b6b69c2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I didn't use that. Good idea, thank you.