Gradle - Resolve platform properties when possible #45681
Merged
+35
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were always passing a <<ignored>> value for the native builder which is a problem. We now correctly get the values from the platform properties when possible.
quarkus-bot
bot
added
area/devtools
gsmet
added
triage/backport-3.15
triage/backport-3.17
triage/backport
and removed
triage/backport-3.15
labels
aloubyansky
reviewed
Jan 17, 2025
| @@ -117,7 +117,8 @@ protected Manifest manifest() { | |||
| return baseConfig().manifest(); | |||
| } | |||
|
|
|||
| protected EffectiveConfig buildEffectiveConfiguration(ResolvedDependency appArtifact) { | |||
| protected EffectiveConfig buildEffectiveConfiguration(ResolvedDependency appArtifact, | |||
| Map<String, String> platformProperties) { | |||
There was a problem hiding this comment.
A minor comment, it looks like you could pass an ApplicationModel here now? Every invocation seems to be obtaining the two arguments from it.
There was a problem hiding this comment.
Yeah, I tried to reduce my changes to the minimum. I pushed an additional commit.
aloubyansky
approved these changes
Jan 17, 2025
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always passing a
<<ignored>>value for the native builder which is a problem.We now correctly get the values from the platform properties when possible.
This is a follow-up for #45637 .