Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check log categories without named handlers #45705

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

rquinio1A
Copy link
Contributor

In #initializeBuildTimeLogging, do not check the log handlers associaciated to categories are valid, as it only considers the core handlers. The check is re-done in #initializeLogging, where all handlers are taken into account.

Fixes #45645

This comment was marked as resolved.

@rquinio1A rquinio1A changed the title fix: do not check categories without named handlers Do not check log categories without named handlers Jan 20, 2025
@rquinio1A rquinio1A force-pushed the bugfix/named-handler-categories branch from 9c67616 to 6f08f07 Compare January 20, 2025 07:53
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added triage/backport triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 20, 2025
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand merged commit 47a1a8c into quarkusio:main Jan 20, 2025
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 20, 2025
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 20, 2025
Copy link

quarkus-bot bot commented Jan 20, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 6f08f07.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet modified the milestones: 3.19 - main, 3.18.0 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NamedLogHandlersBuildItem causes stderr "Handler is linked to a category but not configured"
3 participants