Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert jackson module to use @ConfigMapping #45712

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Convert jackson module to use @ConfigMapping #45712

merged 2 commits into from
Jan 21, 2025

Conversation

IvanPetkov23
Copy link
Contributor

Part of #45446

@quarkus-bot quarkus-bot bot added the area/jackson Issues related to Jackson (JSON library) label Jan 20, 2025
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

🎊 PR Preview c2fe311 has been successfully built and deployed to https://quarkus-pr-main-45712-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I requested a few changes.

extensions/jackson/runtime/src/main/java/io/quarkus/jackson/runtime/JacksonBuildTimeConfig.java Outdated Show resolved Hide resolved
extensions/jackson/runtime/src/main/java/io/quarkus/jackson/runtime/JacksonBuildTimeConfig.java Outdated Show resolved Hide resolved
@IvanPetkov23 IvanPetkov23 requested a review from gsmet January 20, 2025 14:16
gsmet
gsmet approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be all good now. Let's see what CI says!

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 21, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 21, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b7b742e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 21, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b7b742e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi merged commit 01d99ba into quarkusio:main Jan 21, 2025
54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 21, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 21, 2025
@gsmet
Copy link
Member

gsmet commented Jan 21, 2025

Thanks for the PR!

@IvanPetkov23 IvanPetkov23 deleted the feature/jackson branch January 21, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manofthepeace manofthepeace manofthepeace left review comments

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/jackson Issues related to Jackson (JSON library)
Projects
None yet
Milestone
3.19 - main
Development

Successfully merging this pull request may close these issues.
4 participants
@IvanPetkov23 @gsmet @manofthepeace @gastaldi