Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop FAQ entry about non-existing modules, remove irrelevant mentions about Java 8 #45724

Merged
merged 2 commits into from
Jan 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -882,10 +882,6 @@ This project is an open source project, please act responsibly, be nice, polite

See section `IDEA Setup` as there are different possible solutions described.

* IntelliJ does not recognize the project as a Java 17 project

In the Maven pane, uncheck the `include-jdk-misc` and `compile-java8-release-flag` profiles

* Build hangs with DevMojoIT running infinitely

```shell
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,7 @@ public class AvroOptions {

/**
* The createOptionalGetters parameter enables generating the getOptional...
* methods that return an Optional of the requested type. This works ONLY on
* Java 8+
* methods that return an Optional of the requested type.
*/
final boolean createOptionalGetters;

Expand All @@ -138,16 +137,15 @@ public class AvroOptions {

/**
* The gettersReturnOptional parameter enables generating get... methods that
* return an Optional of the requested type. This will replace the This works
* ONLY on Java 8+
* return an Optional of the requested type.
*/
final boolean gettersReturnOptional;

/**
* The optionalGettersForNullableFieldsOnly parameter works in conjunction with
* gettersReturnOptional option. If it is set, Optional getters will be
* generated only for fields that are nullable. If the field is mandatory,
* regular getter will be generated. This works ONLY on Java 8+.
* regular getter will be generated.
*/
final boolean optionalGettersForNullableFieldsOnly;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,7 @@ public abstract class PathTreeWithManifest implements PathTree {
List<Integer> list = (List<Integer>) v.getClass().getMethod(versionStr).invoke(v);
JAVA_VERSION = list.get(0);
} catch (Exception e) {
//version 8
throw new IllegalStateException(
"Failed to obtain the Java version from java.lang.Runtime, possibly it's Java 8 which is not supported anymore",
e);
throw new IllegalStateException("Failed to obtain the Java version from java.lang.Runtime", e);
}
}

Expand Down
Loading