Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wait strategy usage, Grafana should not know about LGTM #45734

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Fix wait strategy usage, Grafana should not know about LGTM #45734

merged 1 commit into from
Jan 21, 2025
+19 −14

Conversation

alesj
Copy link
Contributor

@alesj alesj commented Jan 21, 2025

Move LGTM "awereness" to the right container.

@alesj alesj requested review from geoand and gsmet January 21, 2025 06:12
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 21, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 449b87c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 5534ed1 into quarkusio:main Jan 21, 2025
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 21, 2025
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.0 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alesj @geoand @gsmet